Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2086633002: Revert of Remove audio/video distinction for probe packets. (Closed)

Created:
4 years, 6 months ago by honghaiz3
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove audio/video distinction for probe packets. (patchset #2 id:20001 of https://codereview.webrtc.org/2061193002/ ) Reason for revert: Revert this because it broke a downstream build. Original issue's description: > Remove audio/video distinction for probe packets. > > Allows detecting large-enough audio packets as part of a probe, > speculative fix for a rampup-time regression in M50. These packets are > accounted on the send side when probing. > > BUG=webrtc:5985 > R=mflodman@webrtc.org, philipel@webrtc.org > > Committed: https://crrev.com/a7d88d38448f6a5677a017562765ab505b89d468 > Cr-Commit-Position: refs/heads/master@{#13210} TBR=mflodman@webrtc.org,philipel@webrtc.org,pbos@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5985 Committed: https://crrev.com/17bde8c96ee8b5a7e496a7dc98828b84f9756925 Cr-Commit-Position: refs/heads/master@{#13221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -145 lines) Patch
M webrtc/audio/audio_receive_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.h View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc View 13 chunks +18 lines, -13 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/mock/mock_remote_bitrate_estimator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/send_time_history.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 4 chunks +16 lines, -14 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc View 11 chunks +19 lines, -13 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc View 10 chunks +16 lines, -15 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc View 10 chunks +54 lines, -35 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp_play.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc View 6 chunks +19 lines, -18 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 4 chunks +8 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
honghaiz3
Created Revert of Remove audio/video distinction for probe packets.
4 years, 6 months ago (2016-06-20 18:46:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086633002/1
4 years, 6 months ago (2016-06-20 18:47:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 18:47:21 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/17bde8c96ee8b5a7e496a7dc98828b84f9756925 Cr-Commit-Position: refs/heads/master@{#13221}
4 years, 6 months ago (2016-06-20 18:47:31 UTC) #7
pbos-webrtc
4 years, 6 months ago (2016-06-20 18:52:36 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2085653002/ by pbos@webrtc.org.

The reason for reverting is: Fix already landed in google3, this revert actually
breaks the import..

Powered by Google App Engine
This is Rietveld 408576698