NetEq: Fix a bug in DelayPeakDetector causing asserts to trigger

NetEq: Fix a bug in DelayPeakDetector causing asserts to trigger

In some situation, typically when incoming packets were reordered, the
DelayPeakDetector::Update method may be called twice (or more) with
non-zero inter_arrival_time argument, but without the TickTimer object
being updated in between (i.e., packets coming in more or less at the
same time). In these situations, a delay peak may be registered with
zero peak period. This could eventually trigger the DCHECK in
DelayPeakDetector::MaxPeakPeriod().

With this fix, the problem is solved by not registering peaks for which
the TickTimer object has not moved since the last peak.

The problem was originally introduced with
https://codereview.webrtc.org/1921163003.

BUG=webrtc:6021
Committed: https://crrev.com/d5f50a1b53f740b7273fc859b6c832af21daa473
Cr-Commit-Position: refs/heads/master@{#13257}

[hlundin-webrtc, 2016-06-22 12:11:53]

henrik.lundin@webrtc.org changed reviewers:
+ tina.legrand@webrtc.org

[hlundin-webrtc, 2016-06-22 12:11:53]

Tina,

Can you review this bug fix?

Thanks!

[tlegrand-webrtc, 2016-06-22 13:56:14]

lgtm

[hlundin-webrtc, 2016-06-22 15:35:09]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-06-22 15:35:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085233002/1

[commit-bot: I haz the power, 2016-06-22 16:07:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-22 16:07:11]

Description was changed from

==========
NetEq: Fix a bug in DelayPeakDetector causing asserts to trigger

In some situation, typically when incoming packets were reordered, the
DelayPeakDetector::Update method may be called twice (or more) with
non-zero inter_arrival_time argument, but without the TickTimer object
being updated in between (i.e., packets coming in more or less at the
same time). In these situations, a delay peak may be registered with
zero peak period. This could eventually trigger the DCHECK in
DelayPeakDetector::MaxPeakPeriod().

With this fix, the problem is solved by not registering peaks for which
the TickTimer object has not moved since the last peak.

The problem was originally introduced with
https://codereview.webrtc.org/1921163003.

BUG=webrtc:6021
==========

to

==========
NetEq: Fix a bug in DelayPeakDetector causing asserts to trigger

In some situation, typically when incoming packets were reordered, the
DelayPeakDetector::Update method may be called twice (or more) with
non-zero inter_arrival_time argument, but without the TickTimer object
being updated in between (i.e., packets coming in more or less at the
same time). In these situations, a delay peak may be registered with
zero peak period. This could eventually trigger the DCHECK in
DelayPeakDetector::MaxPeakPeriod().

With this fix, the problem is solved by not registering peaks for which
the TickTimer object has not moved since the last peak.

The problem was originally introduced with
https://codereview.webrtc.org/1921163003.

BUG=webrtc:6021

Committed: https://crrev.com/d5f50a1b53f740b7273fc859b6c832af21daa473
Cr-Commit-Position: refs/heads/master@{#13257}
==========

[commit-bot: I haz the power, 2016-06-22 16:07:12]

Patchset 1 (id:??) landed as
https://crrev.com/d5f50a1b53f740b7273fc859b6c832af21daa473
Cr-Commit-Position: refs/heads/master@{#13257}