Revert of Split IncomingVideoStream into two implementations, with smoothing and without.

Revert of Split IncomingVideoStream into two implementations, with smoothing and without. (patchset #5 id:340001 of https://codereview.webrtc.org/2078873002/ )

Reason for revert:
Breaks chromium.webrtc.fyi

https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win7%20Tester/builds/4719
https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win10%20Tester/builds/3120

Original issue's description:
> Reland of IncomingVideoStream refactoring.
> This reland does not contain the non-smoothing part of the original implementation.  Instead, when smoothing is turned off, frame callbacks run on the decoder thread, as they did before.  This code path is used in Chrome.  As far as Chrome goes, the difference now is that there won't be an instance of IncomingVideoStream in between the decoder and the callback (i.e. fewer locks).  Other than that, no change for Chrome.
>
> Original issue's description (with non-smoothing references removed):
>
> Split IncomingVideoStream into two implementations, with smoothing and without.
>
> * Added TODOs and documentation for VideoReceiveStream::OnFrame, where we today grab 6 locks.
>
> * Removed the Start/Stop methods from the IncomingVideoStream implementations.  Now, when an instance is created, it should be considered to be "running" and when it is deleted, it's "not running".  This saves on resources and also reduces the amount of locking required and I could remove one critical section altogether.
>
> * Changed the VideoStreamDecoder class to not depend on IncomingVideoStream but rather use the generic rtc::VideoSinkInterface<VideoFrame> interface.  This means that any implementation of that interface can be used and the decoder can be made to  just use the 'renderer' from the config.  Once we do that, we can decouple the IncomingVideoStream implementations from the decoder and VideoReceiveStream implementations and leave it up to the application for how to do smoothing.  The app can choose to use the Incoming* classes or roll its own (which may be preferable since applications often have their own scheduling mechanisms).
>
> * The lifetime of the VideoStreamDecoder instance is now bound to Start/Stop in VideoReceiveStream and not all of the lifetime of VideoReceiveStream.
>
> * Fixed VideoStreamDecoder to unregister callbacks in the dtor that were registered in the ctor. (this was open to a use-after-free regression)
>
> * Delay and callback pointers are now passed via the ctors to the IncomingVideoStream classes.  The thread primitives in the IncomingVideoStream classes are also constructed/destructed at the same time as the owning object, which allowed me to remove one more lock.
>
> * Removed code in the VideoStreamDecoder that could overwrite the VideoReceiveStream render delay with a fixed value of 10ms on construction.  This wasn't a problem with the previous implementation (it would be now though) but seemed to me like the wrong place to be setting that value.
>
> * Made the render delay value in VideoRenderFrames, const.
>
> BUG=chromium:620232
> R=mflodman@webrtc.org, nisse@webrtc.org
>
> Committed: https://crrev.com/884c336c345d988974c2a69cea402b0fb8b07a63
> Cr-Commit-Position: refs/heads/master@{#13219}

TBR=nisse@webrtc.org,philipel@webrtc.org,mflodman@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:620232
Committed: https://crrev.com/a536bfe70de38fe877245317a7f0b00bcf69cbd0
Cr-Commit-Position: refs/heads/master@{#13229}

[sakal, 2016-06-21 07:08:33]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-06-21 07:08:33]

Created Revert of Split IncomingVideoStream into two implementations, with
smoothing and without.

[commit-bot: I haz the power, 2016-06-21 07:08:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084873002/1

[commit-bot: I haz the power, 2016-06-21 07:08:52]

Description was changed from

==========
Revert of Split IncomingVideoStream into two implementations, with smoothing and
without. (patchset #5 id:340001 of https://codereview.webrtc.org/2078873002/ )

Reason for revert:
Breaks chromium.webrtc.fyi

https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win7%20Te...
https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win10%20T...

Original issue's description:
> Reland of IncomingVideoStream refactoring.
> This reland does not contain the non-smoothing part of the original
implementation.  Instead, when smoothing is turned off, frame callbacks run on
the decoder thread, as they did before.  This code path is used in Chrome.  As
far as Chrome goes, the difference now is that there won't be an instance of
IncomingVideoStream in between the decoder and the callback (i.e. fewer locks). 
Other than that, no change for Chrome.
> 
> Original issue's description (with non-smoothing references removed):
> 
> Split IncomingVideoStream into two implementations, with smoothing and
without.
> 
> * Added TODOs and documentation for VideoReceiveStream::OnFrame, where we
today grab 6 locks.
> 
> * Removed the Start/Stop methods from the IncomingVideoStream implementations.
 Now, when an instance is created, it should be considered to be "running" and
when it is deleted, it's "not running".  This saves on resources and also
reduces the amount of locking required and I could remove one critical section
altogether.
> 
> * Changed the VideoStreamDecoder class to not depend on IncomingVideoStream
but rather use the generic rtc::VideoSinkInterface<VideoFrame> interface.  This
means that any implementation of that interface can be used and the decoder can
be made to  just use the 'renderer' from the config.  Once we do that, we can
decouple the IncomingVideoStream implementations from the decoder and
VideoReceiveStream implementations and leave it up to the application for how to
do smoothing.  The app can choose to use the Incoming* classes or roll its own
(which may be preferable since applications often have their own scheduling
mechanisms).
> 
> * The lifetime of the VideoStreamDecoder instance is now bound to Start/Stop
in VideoReceiveStream and not all of the lifetime of VideoReceiveStream.
> 
> * Fixed VideoStreamDecoder to unregister callbacks in the dtor that were
registered in the ctor. (this was open to a use-after-free regression)
> 
> * Delay and callback pointers are now passed via the ctors to the
IncomingVideoStream classes.  The thread primitives in the IncomingVideoStream
classes are also constructed/destructed at the same time as the owning object,
which allowed me to remove one more lock.
> 
> * Removed code in the VideoStreamDecoder that could overwrite the
VideoReceiveStream render delay with a fixed value of 10ms on construction. 
This wasn't a problem with the previous implementation (it would be now though)
but seemed to me like the wrong place to be setting that value.
> 
> * Made the render delay value in VideoRenderFrames, const.
> 
> BUG=chromium:620232
> R=mflodman@webrtc.org, nisse@webrtc.org
> 
> Committed: https://crrev.com/884c336c345d988974c2a69cea402b0fb8b07a63
> Cr-Commit-Position: refs/heads/master@{#13219}

TBR=nisse@webrtc.org,philipel@webrtc.org,mflodman@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:620232
==========

to

==========
Revert of Split IncomingVideoStream into two implementations, with smoothing and
without. (patchset #5 id:340001 of https://codereview.webrtc.org/2078873002/ )

Reason for revert:
Breaks chromium.webrtc.fyi

https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win7%20Te...
https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win10%20T...

Original issue's description:
> Reland of IncomingVideoStream refactoring.
> This reland does not contain the non-smoothing part of the original
implementation.  Instead, when smoothing is turned off, frame callbacks run on
the decoder thread, as they did before.  This code path is used in Chrome.  As
far as Chrome goes, the difference now is that there won't be an instance of
IncomingVideoStream in between the decoder and the callback (i.e. fewer locks). 
Other than that, no change for Chrome.
> 
> Original issue's description (with non-smoothing references removed):
> 
> Split IncomingVideoStream into two implementations, with smoothing and
without.
> 
> * Added TODOs and documentation for VideoReceiveStream::OnFrame, where we
today grab 6 locks.
> 
> * Removed the Start/Stop methods from the IncomingVideoStream implementations.
 Now, when an instance is created, it should be considered to be "running" and
when it is deleted, it's "not running".  This saves on resources and also
reduces the amount of locking required and I could remove one critical section
altogether.
> 
> * Changed the VideoStreamDecoder class to not depend on IncomingVideoStream
but rather use the generic rtc::VideoSinkInterface<VideoFrame> interface.  This
means that any implementation of that interface can be used and the decoder can
be made to  just use the 'renderer' from the config.  Once we do that, we can
decouple the IncomingVideoStream implementations from the decoder and
VideoReceiveStream implementations and leave it up to the application for how to
do smoothing.  The app can choose to use the Incoming* classes or roll its own
(which may be preferable since applications often have their own scheduling
mechanisms).
> 
> * The lifetime of the VideoStreamDecoder instance is now bound to Start/Stop
in VideoReceiveStream and not all of the lifetime of VideoReceiveStream.
> 
> * Fixed VideoStreamDecoder to unregister callbacks in the dtor that were
registered in the ctor. (this was open to a use-after-free regression)
> 
> * Delay and callback pointers are now passed via the ctors to the
IncomingVideoStream classes.  The thread primitives in the IncomingVideoStream
classes are also constructed/destructed at the same time as the owning object,
which allowed me to remove one more lock.
> 
> * Removed code in the VideoStreamDecoder that could overwrite the
VideoReceiveStream render delay with a fixed value of 10ms on construction. 
This wasn't a problem with the previous implementation (it would be now though)
but seemed to me like the wrong place to be setting that value.
> 
> * Made the render delay value in VideoRenderFrames, const.
> 
> BUG=chromium:620232
> R=mflodman@webrtc.org, nisse@webrtc.org
> 
> Committed: https://crrev.com/884c336c345d988974c2a69cea402b0fb8b07a63
> Cr-Commit-Position: refs/heads/master@{#13219}

TBR=nisse@webrtc.org,philipel@webrtc.org,mflodman@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:620232
==========

[commit-bot: I haz the power, 2016-06-21 07:08:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-21 07:09:07]

Description was changed from

==========
Revert of Split IncomingVideoStream into two implementations, with smoothing and
without. (patchset #5 id:340001 of https://codereview.webrtc.org/2078873002/ )

Reason for revert:
Breaks chromium.webrtc.fyi

https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win7%20Te...
https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win10%20T...

Original issue's description:
> Reland of IncomingVideoStream refactoring.
> This reland does not contain the non-smoothing part of the original
implementation.  Instead, when smoothing is turned off, frame callbacks run on
the decoder thread, as they did before.  This code path is used in Chrome.  As
far as Chrome goes, the difference now is that there won't be an instance of
IncomingVideoStream in between the decoder and the callback (i.e. fewer locks). 
Other than that, no change for Chrome.
> 
> Original issue's description (with non-smoothing references removed):
> 
> Split IncomingVideoStream into two implementations, with smoothing and
without.
> 
> * Added TODOs and documentation for VideoReceiveStream::OnFrame, where we
today grab 6 locks.
> 
> * Removed the Start/Stop methods from the IncomingVideoStream implementations.
 Now, when an instance is created, it should be considered to be "running" and
when it is deleted, it's "not running".  This saves on resources and also
reduces the amount of locking required and I could remove one critical section
altogether.
> 
> * Changed the VideoStreamDecoder class to not depend on IncomingVideoStream
but rather use the generic rtc::VideoSinkInterface<VideoFrame> interface.  This
means that any implementation of that interface can be used and the decoder can
be made to  just use the 'renderer' from the config.  Once we do that, we can
decouple the IncomingVideoStream implementations from the decoder and
VideoReceiveStream implementations and leave it up to the application for how to
do smoothing.  The app can choose to use the Incoming* classes or roll its own
(which may be preferable since applications often have their own scheduling
mechanisms).
> 
> * The lifetime of the VideoStreamDecoder instance is now bound to Start/Stop
in VideoReceiveStream and not all of the lifetime of VideoReceiveStream.
> 
> * Fixed VideoStreamDecoder to unregister callbacks in the dtor that were
registered in the ctor. (this was open to a use-after-free regression)
> 
> * Delay and callback pointers are now passed via the ctors to the
IncomingVideoStream classes.  The thread primitives in the IncomingVideoStream
classes are also constructed/destructed at the same time as the owning object,
which allowed me to remove one more lock.
> 
> * Removed code in the VideoStreamDecoder that could overwrite the
VideoReceiveStream render delay with a fixed value of 10ms on construction. 
This wasn't a problem with the previous implementation (it would be now though)
but seemed to me like the wrong place to be setting that value.
> 
> * Made the render delay value in VideoRenderFrames, const.
> 
> BUG=chromium:620232
> R=mflodman@webrtc.org, nisse@webrtc.org
> 
> Committed: https://crrev.com/884c336c345d988974c2a69cea402b0fb8b07a63
> Cr-Commit-Position: refs/heads/master@{#13219}

TBR=nisse@webrtc.org,philipel@webrtc.org,mflodman@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:620232
==========

to

==========
Revert of Split IncomingVideoStream into two implementations, with smoothing and
without. (patchset #5 id:340001 of https://codereview.webrtc.org/2078873002/ )

Reason for revert:
Breaks chromium.webrtc.fyi

https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win7%20Te...
https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win10%20T...

Original issue's description:
> Reland of IncomingVideoStream refactoring.
> This reland does not contain the non-smoothing part of the original
implementation.  Instead, when smoothing is turned off, frame callbacks run on
the decoder thread, as they did before.  This code path is used in Chrome.  As
far as Chrome goes, the difference now is that there won't be an instance of
IncomingVideoStream in between the decoder and the callback (i.e. fewer locks). 
Other than that, no change for Chrome.
>
> Original issue's description (with non-smoothing references removed):
>
> Split IncomingVideoStream into two implementations, with smoothing and
without.
>
> * Added TODOs and documentation for VideoReceiveStream::OnFrame, where we
today grab 6 locks.
>
> * Removed the Start/Stop methods from the IncomingVideoStream implementations.
 Now, when an instance is created, it should be considered to be "running" and
when it is deleted, it's "not running".  This saves on resources and also
reduces the amount of locking required and I could remove one critical section
altogether.
>
> * Changed the VideoStreamDecoder class to not depend on IncomingVideoStream
but rather use the generic rtc::VideoSinkInterface<VideoFrame> interface.  This
means that any implementation of that interface can be used and the decoder can
be made to  just use the 'renderer' from the config.  Once we do that, we can
decouple the IncomingVideoStream implementations from the decoder and
VideoReceiveStream implementations and leave it up to the application for how to
do smoothing.  The app can choose to use the Incoming* classes or roll its own
(which may be preferable since applications often have their own scheduling
mechanisms).
>
> * The lifetime of the VideoStreamDecoder instance is now bound to Start/Stop
in VideoReceiveStream and not all of the lifetime of VideoReceiveStream.
>
> * Fixed VideoStreamDecoder to unregister callbacks in the dtor that were
registered in the ctor. (this was open to a use-after-free regression)
>
> * Delay and callback pointers are now passed via the ctors to the
IncomingVideoStream classes.  The thread primitives in the IncomingVideoStream
classes are also constructed/destructed at the same time as the owning object,
which allowed me to remove one more lock.
>
> * Removed code in the VideoStreamDecoder that could overwrite the
VideoReceiveStream render delay with a fixed value of 10ms on construction. 
This wasn't a problem with the previous implementation (it would be now though)
but seemed to me like the wrong place to be setting that value.
>
> * Made the render delay value in VideoRenderFrames, const.
>
> BUG=chromium:620232
> R=mflodman@webrtc.org, nisse@webrtc.org
>
> Committed: https://crrev.com/884c336c345d988974c2a69cea402b0fb8b07a63
> Cr-Commit-Position: refs/heads/master@{#13219}

TBR=nisse@webrtc.org,philipel@webrtc.org,mflodman@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:620232

Committed: https://crrev.com/a536bfe70de38fe877245317a7f0b00bcf69cbd0
Cr-Commit-Position: refs/heads/master@{#13229}
==========

[commit-bot: I haz the power, 2016-06-21 07:09:08]

Patchset 1 (id:??) landed as
https://crrev.com/a536bfe70de38fe877245317a7f0b00bcf69cbd0
Cr-Commit-Position: refs/heads/master@{#13229}

[tommi, 2016-06-21 07:26:27]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2089613002/ by tommi@webrtc.org.

The reason for reverting is: Reverting the revert.  This change is not related
to the failure on the Windows FYI bots.  The cause of the failure has been
reverted in Chromium:
https://codereview.chromium.org/2081653004/.