Fix IPv6 support issue.

webrtc/p2p/base/turnport_unittest.cc

 /*
  *  Copyright 2012 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 #if defined(WEBRTC_POSIX)
@@ skipping 26 matching lines @@
 using cricket::Connection;
 using cricket::Port;
 using cricket::PortInterface;
 using cricket::TurnPort;
 using cricket::UDPPort;
 
 static const SocketAddress kLocalAddr1("11.11.11.11", 0);
 static const SocketAddress kLocalAddr2("22.22.22.22", 0);
 static const SocketAddress kLocalIPv6Addr(
     "2401:fa00:4:1000:be30:5bff:fee5:c3", 0);
+static const SocketAddress kLocalIPv6Addr2(
+    "2401:fa00:4:2000:be30:5bff:fee5:d4", 0);
 static const SocketAddress kTurnUdpIntAddr("99.99.99.3",
                                            cricket::TURN_SERVER_PORT);
 static const SocketAddress kTurnTcpIntAddr("99.99.99.4",
                                            cricket::TURN_SERVER_PORT);
 static const SocketAddress kTurnUdpExtAddr("99.99.99.5", 0);
 static const SocketAddress kTurnAlternateIntAddr("99.99.99.6",
                                                  cricket::TURN_SERVER_PORT);
 static const SocketAddress kTurnIntAddr("99.99.99.7",
                                         cricket::TURN_SERVER_PORT);
 static const SocketAddress kTurnIPv6IntAddr(
     "2400:4030:2:2c00:be30:abcd:efab:cdef",
     cricket::TURN_SERVER_PORT);
 static const SocketAddress kTurnUdpIPv6IntAddr(
     "2400:4030:1:2c00:be30:abcd:efab:cdef", cricket::TURN_SERVER_PORT);
-static const SocketAddress kTurnUdpIPv6ExtAddr(
-  "2620:0:1000:1b03:2e41:38ff:fea6:f2a4", 0);
 
 static const char kIceUfrag1[] = "TESTICEUFRAG0001";
 static const char kIceUfrag2[] = "TESTICEUFRAG0002";
 static const char kIcePwd1[] = "TESTICEPWD00000000000001";
 static const char kIcePwd2[] = "TESTICEPWD00000000000002";
 static const char kTurnUsername[] = "test";
 static const char kTurnPassword[] = "test";
 static const char kTestOrigin[] = "http://example.com";
 static const unsigned int kTimeout = 1000;
 
@@ skipping 508 matching lines @@
   turn_port_->PrepareAddress();
   EXPECT_TRUE_WAIT(turn_error_, kTimeout);
   // As VSS doesn't provide a DNS resolution, name resolve will fail. TurnPort
   // will proceed in creating a TCP socket which will fail as there is no
   // server on the above domain and error will be set to SOCKET_ERROR.
   EXPECT_EQ(SOCKET_ERROR, turn_port_->error());
 }
 
 // In case of UDP on address resolve failure, TurnPort will not create socket
 // and return allocate failure.
-TEST_F(TurnPortTest, DISABLED_TestTurnUdpOnAdressResolveFailure) {
+TEST_F(TurnPortTest, DISABLED_TestTurnUdpOnAddressResolveFailure) {
   CreateTurnPort(kTurnUsername, kTurnPassword, cricket::ProtocolAddress(

[pthatcher1, 2016/06/21 05:26:54]

Can we un-DISABLED the test?

[honghaiz3, 2016/06/21 18:36:06]

Will do this in a separate CL, as it was typically because it is flaky, and I
would prefer this CL being revert due to re-enabling a flaky test. 

       rtc::SocketAddress("www.webrtc-blah-blah.com", 3478),
       cricket::PROTO_UDP));
   turn_port_->PrepareAddress();
   EXPECT_TRUE_WAIT(turn_error_, kTimeout);
   // Error from turn port will not be socket error.
   EXPECT_NE(SOCKET_ERROR, turn_port_->error());
 }
 
 // Try to do a TURN allocation with an invalid password.
 TEST_F(TurnPortTest, TestTurnAllocateBadPassword) {
@@ skipping 373 matching lines @@
   CreateTurnPort(kLocalIPv6Addr, kTurnUsername, kTurnPassword,
                  kTurnUdpIPv6ProtoAddr);
   turn_port_->PrepareAddress();
   EXPECT_TRUE_WAIT(turn_ready_, kTimeout);
   ASSERT_EQ(1U, turn_port_->Candidates().size());
   EXPECT_EQ(kTurnUdpExtAddr.ipaddr(),
             turn_port_->Candidates()[0].address().ipaddr());
   EXPECT_NE(0, turn_port_->Candidates()[0].address().port());
 }
 
+// Tests that the local and remote candidate address family should match when

[pthatcher1, 2016/06/21 05:26:54]

family = families

[honghaiz3, 2016/06/21 18:36:06]

Done.

+// a connection is created. Specially if a turn port has an IPv6 address, its

[pthatcher1, 2016/06/21 05:26:54]

Specially -> Specifically,

?

[Taylor Brandstetter, 2016/06/21 17:20:31]

Can you capitalize TURN consistently here and below?

[honghaiz3, 2016/06/21 18:36:06]

Done.

+// local candidate will still be an IPv4 address and it can only create
+// connections with IPv4 remote candidates.
+TEST_F(TurnPortTest, TestCandidateAddressFamilyMatch) {
+  rtc::ScopedFakeClock clock;

[Taylor Brandstetter, 2016/06/21 17:20:31]

I don't know why the fake clock is necessary here. Does this test deal with any
timeouts? It doesn't hurt though; I'm just curious.

[honghaiz3, 2016/06/21 18:36:06]

If we have to wait for some state change with a timeout, it has a chance to be
flaky with real clock, right? Although the chance is pretty small here. 

[Taylor Brandstetter, 2016/06/21 19:26:48]

The general solution in that case is to use a longer timeout. I would suggest
changing kTimeout to 10 seconds or more. But if there is a race condition when
using a real clock, then the fake clock would make sense.

[honghaiz3, 2016/06/21 20:06:49]

Removed the fake clock but keep the kTimeout. I think we may consider changing
it to 10 second if we see this or similar tests are flaky because 1 second is
not enough. 

+  turn_server_.AddInternalSocket(kTurnUdpIPv6IntAddr, cricket::PROTO_UDP);
+
+  CreateTurnPort(kLocalIPv6Addr, kTurnUsername, kTurnPassword,
+                 kTurnUdpIPv6ProtoAddr);
+  turn_port_->PrepareAddress();
+  EXPECT_TRUE_SIMULATED_WAIT(turn_ready_, kTimeout, clock);
+  ASSERT_EQ(1U, turn_port_->Candidates().size());
+
+  // Create an IPv4 port. Its candidate will match the Turn candidate.

[pthatcher1, 2016/06/21 05:26:54]

TURN

[honghaiz3, 2016/06/21 18:36:06]

Done.

+  CreateUdpPort();

[Taylor Brandstetter, 2016/06/21 17:20:31]

Why do you need to create actual remote ports? Couldn't you call
CreateConnection with a fake candidate that the test constructs?

[honghaiz3, 2016/06/21 18:36:06]

Done. 

+  udp_port_->PrepareAddress();
+  EXPECT_TRUE_SIMULATED_WAIT(udp_ready_, kTimeout);
+  Connection* conn = turn_port_->CreateConnection(udp_port_->Candidates()[0],
+                                                  Port::ORIGIN_MESSAGE);
+  EXPECT_TRUE(conn != nullptr);

[Taylor Brandstetter, 2016/06/21 17:20:31]

EXPECT_NE(nullptr, conn)?

[honghaiz3, 2016/06/21 18:36:06]

Done.

+
+  // Create an IPv6 UDP port. Its candidate won't match the Turn candidate.

[pthatcher1, 2016/06/21 05:26:54]

TURN

[honghaiz3, 2016/06/21 18:36:06]

Done.

+  CreateUdpPort(kLocalIPv6Addr2);
+  udp_port_->PrepareAddress();
+  EXPECT_TRUE_SIMULATED_WAIT(udp_ready_, kTimeout);
+  conn = turn_port_->CreateConnection(udp_port_->Candidates()[0],
+                                      Port::ORIGIN_MESSAGE);
+  EXPECT_TRUE(conn == nullptr);

[Taylor Brandstetter, 2016/06/21 17:20:31]

EXPECT_EQ(nullptr, conn)?

[honghaiz3, 2016/06/21 18:36:06]

Done.

+}
+
 TEST_F(TurnPortTest, TestOriginHeader) {
   CreateTurnPortWithOrigin(kLocalAddr1, kTurnUsername, kTurnPassword,
                            kTurnUdpProtoAddr, kTestOrigin);
   turn_port_->PrepareAddress();
   EXPECT_TRUE_WAIT(turn_ready_, kTimeout);
   ASSERT_GT(turn_server_.server()->allocations().size(), 0U);
   SocketAddress local_address = turn_port_->GetLocalAddress();
   ASSERT_TRUE(turn_server_.FindAllocation(local_address) != NULL);
   EXPECT_EQ(kTestOrigin, turn_server_.FindAllocation(local_address)->origin());
 }
@@ skipping 61 matching lines @@
   turn_port_->PrepareAddress();
   ASSERT_TRUE_WAIT(turn_error_, kResolverTimeout);
   EXPECT_TRUE(turn_port_->Candidates().empty());
   turn_port_.reset();
   rtc::Thread::Current()->Post(RTC_FROM_HERE, this, MSG_TESTFINISH);
   // Waiting for above message to be processed.
   ASSERT_TRUE_WAIT(test_finish_, kTimeout);
   EXPECT_EQ(last_fd_count, GetFDCount());
 }
 #endif