Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2082573004: Exclude libjingle_peerconnection_{jni,so} targets from Chromium builds. (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Exclude libjingle_peerconnection_{jni,so} targets from Chromium builds. In GN, the libjingle_peerconnection_jni target becomes a part of 'all' implicitly, which surfaced the incompability between it and the Chromium logging implementation. In the GYP build, the target is not present due to api.gyp not being depended upon yet. BUG=webrtc:4256 TBR=perkj@webrtc.org NOTRY=True Committed: https://crrev.com/69b34625c1ee2f527e481c420ff1294851463b77 Cr-Commit-Position: refs/heads/master@{#13231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/api/api.gyp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-21 08:02:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082573004/1
4 years, 6 months ago (2016-06-21 08:04:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 08:05:20 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 08:05:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69b34625c1ee2f527e481c420ff1294851463b77
Cr-Commit-Position: refs/heads/master@{#13231}

Powered by Google App Engine
This is Rietveld 408576698