voice_engine: Removed old variants of Channel constructor and CreateChannel

voice_engine: Removed old variants of Channel constructor and CreateChannel

These are no longer used internally and their interface is not to be
considered public. They were due to be changed in
https://codereview.webrtc.org/1993783002/ but remained due to a
misunderstanding.

Committed: https://crrev.com/e1f5b4a7fe8c16a891042173c2e357c48fef4ad3
Cr-Commit-Position: refs/heads/master@{#13816}

[ossu, 2016-06-20 11:09:44]

ossu@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[ossu, 2016-06-20 11:09:44]

After discussing with Solenberg, it turned out the CreateChannel that needed to
remain unchanged was the one in VoEBase, which was never touched anyways.

[kwiberg-webrtc, 2016-08-12 08:57:32]

lgtm

[ossu, 2016-08-17 14:22:36]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 14:22:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-17 14:23:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 14:23:59]

Dry run: Try jobs failed on following builders:
  ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_dbg/builds/1901)
  ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_rel/builds/1920)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/11933)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/11866)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/17176)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/15828)
  mac_gn_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/5326)
  mac_gn_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/11563)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/17234)

[ossu, 2016-08-17 14:42:47]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 14:42:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-17 16:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 16:43:20]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[ossu, 2016-08-18 09:03:48]

The CQ bit was checked by ossu@webrtc.org

[ossu, 2016-08-18 09:03:48]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2082483003/#ps20001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-08-18 09:03:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-18 11:23:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 11:23:09]

Description was changed from

==========
voice_engine: Removed old variants of Channel constructor and CreateChannel

These are no longer used internally and their interface is not to be
considered public. They were due to be changed in
https://codereview.webrtc.org/1993783002/ but remained due to a
misunderstanding.
==========

to

==========
voice_engine: Removed old variants of Channel constructor and CreateChannel

These are no longer used internally and their interface is not to be
considered public. They were due to be changed in
https://codereview.webrtc.org/1993783002/ but remained due to a
misunderstanding.

Committed: https://crrev.com/e1f5b4a7fe8c16a891042173c2e357c48fef4ad3
Cr-Commit-Position: refs/heads/master@{#13816}
==========

[commit-bot: I haz the power, 2016-08-18 11:23:10]

Patchset 2 (id:??) landed as
https://crrev.com/e1f5b4a7fe8c16a891042173c2e357c48fef4ad3
Cr-Commit-Position: refs/heads/master@{#13816}