Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2081113003: GN: Add neteq_rtpplay and rtc_event_log_source (Closed)

Created:
4 years, 6 months ago by hlundin-webrtc
Modified:
4 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Add neteq_rtpplay and rtc_event_log_source BUG=webrtc:5949 Committed: https://crrev.com/03153f103216ca7140905bf94d91f4183f90438c Cr-Commit-Position: refs/heads/master@{#13239}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Wrap long lines #

Patch Set 3 : Add an s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 2 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hlundin-webrtc
kjellander@, ptal.
4 years, 6 months ago (2016-06-21 11:13:14 UTC) #3
kjellander_webrtc
lgtm with nits https://codereview.webrtc.org/2081113003/diff/1/webrtc/modules/audio_coding/BUILD.gn File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2081113003/diff/1/webrtc/modules/audio_coding/BUILD.gn#newcode957 webrtc/modules/audio_coding/BUILD.gn:957: # Suppress warnings from the Chromium ...
4 years, 6 months ago (2016-06-21 11:21:47 UTC) #4
hlundin-webrtc
Thanks. Will commit this. https://codereview.webrtc.org/2081113003/diff/1/webrtc/modules/audio_coding/BUILD.gn File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2081113003/diff/1/webrtc/modules/audio_coding/BUILD.gn#newcode957 webrtc/modules/audio_coding/BUILD.gn:957: # Suppress warnings from the ...
4 years, 6 months ago (2016-06-21 11:55:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081113003/40001
4 years, 6 months ago (2016-06-21 11:55:28 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-21 12:38:47 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 12:38:55 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/03153f103216ca7140905bf94d91f4183f90438c
Cr-Commit-Position: refs/heads/master@{#13239}

Powered by Google App Engine
This is Rietveld 408576698