Style updates for ForwardErrorCorrection and related classes

webrtc/modules/rtp_rtcp/source/producer_fec.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/rtp_rtcp/source/producer_fec.h"
 
 #include "webrtc/modules/rtp_rtcp/source/byte_io.h"
 #include "webrtc/modules/rtp_rtcp/source/forward_error_correction.h"
 #include "webrtc/modules/rtp_rtcp/source/rtp_utility.h"
 
 namespace webrtc {
 
 enum { kREDForFECHeaderLength = 1 };
 // This controls the maximum amount of excess overhead (actual - target)
-// allowed in order to trigger GenerateFEC(), before |params_.max_fec_frames|
+// allowed in order to trigger GenerateFec(), before |params_.max_fec_frames|
 // is reached. Overhead here is defined as relative to number of media packets.
 enum { kMaxExcessOverhead = 50 };  // Q8.
 // This is the minimum number of media packets required (above some protection
-// level) in order to trigger GenerateFEC(), before |params_.max_fec_frames| is
+// level) in order to trigger GenerateFec(), before |params_.max_fec_frames| is
 // reached.
 enum { kMinimumMediaPackets = 4 };
 // Threshold on the received FEC protection level, above which we enforce at
 // least |kMinimumMediaPackets| packets for the FEC code. Below this
 // threshold |kMinimumMediaPackets| is set to default value of 1.
 enum { kHighProtectionThreshold = 80 };  // Corresponds to ~30 overhead, range
 // is 0 to 255, where 255 corresponds to 100% overhead (relative to number of
 // media packets).
 
 RedPacket::RedPacket(size_t length)
@@ skipping 96 matching lines @@
                                             size_t payload_length,
                                             size_t rtp_header_length) {
   assert(fec_packets_.empty());
   if (media_packets_fec_.empty()) {
     params_ = new_params_;
   }
   bool complete_frame = false;
   const bool marker_bit = (data_buffer[1] & kRtpMarkerBitMask) ? true : false;
   if (media_packets_fec_.size() < ForwardErrorCorrection::kMaxMediaPackets) {
     // Generic FEC can only protect up to kMaxMediaPackets packets.
-    ForwardErrorCorrection::Packet* packet = new ForwardErrorCorrection::Packet;
+    ForwardErrorCorrection::Packet* packet =
+        new ForwardErrorCorrection::Packet();
     packet->length = payload_length + rtp_header_length;
     memcpy(packet->data, data_buffer, packet->length);
     media_packets_fec_.push_back(packet);
   }
   if (marker_bit) {
     ++num_frames_;
     complete_frame = true;
   }
   // Produce FEC over at most |params_.max_fec_frames| frames, or as soon as:
   // (1) the excess overhead (actual overhead - requested/target overhead) is
   // less than |kMaxExcessOverhead|, and
   // (2) at least |minimum_media_packets_fec_| media packets is reached.
   if (complete_frame &&
       (num_frames_ == params_.max_fec_frames ||
           (ExcessOverheadBelowMax() && MinimumMediaPacketsReached()))) {
     assert(num_first_partition_ <=
            static_cast<int>(ForwardErrorCorrection::kMaxMediaPackets));
     // TODO(pbos): Consider whether unequal protection should be enabled or not,
     // it is currently always disabled.
-    int ret = fec_->GenerateFEC(media_packets_fec_, params_.fec_rate,
+    int ret = fec_->GenerateFec(media_packets_fec_, params_.fec_rate,
                                 num_first_partition_, false,
                                 params_.fec_mask_type, &fec_packets_);
     if (fec_packets_.empty()) {
       num_frames_ = 0;
       DeletePackets();
     }
     return ret;
   }
   return 0;
 }
@@ skipping 78 matching lines @@
 
 void ProducerFec::DeletePackets() {
   while (!media_packets_fec_.empty()) {
     delete media_packets_fec_.front();
     media_packets_fec_.pop_front();
   }
   assert(media_packets_fec_.empty());
 }
 
 }  // namespace webrtc