Issue 2079383002: Avoid race when stopping audio unit on iOS

Issue 2079383002: Avoid race when stopping audio unit on iOS (Closed)

Created:
4 years, 6 months ago by henrika_webrtc

Modified:
4 years, 6 months ago

Reviewers:
tkchin_webrtc

CC:
webrtc-reviews_webrtc.org

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Avoid race when stopping audio unit on iOS BUG=webrtc:5993 R=tkchin@webrtc.org Committed: https://crrev.com/41ed7e1715e91818cb70727f9169a24984b070ed Cr-Commit-Position: refs/heads/master@{#13234}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	webrtc/modules/audio_device/ios/audio_device_ios.mm	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	webrtc/modules/audio_device/ios/voice_processing_audio_unit.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (4 generated)

henrika_webrtc

Zeke, PTAL. It feels more safe to stop the audio unit before calling reset on ...

4 years, 6 months ago (2016-06-20 16:29:36 UTC) #3

henrika_webrtc

4 years, 6 months ago (2016-06-21 09:41:20 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
41ed7e1715e91818cb70727f9169a24984b070ed (presubmit successful).