Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2078433003: Revert of -enable UBsan on AGC. (Closed)

Created:
4 years, 6 months ago by pbos-webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of -enable UBsan on AGC. (patchset #1 id:1 of https://codereview.webrtc.org/2063643003/ ) Reason for revert: Breaks downstream code import. Original issue's description: > Reland of Re-enable UBsan on AGC. > > patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/ > > This reverts commit 2b9423f7a18145255deb93f2505a4fd1c3fa9ad7. > > BUG=webrtc:5530 > TBR=peah@webrtc.org, kjellander@webrtc.org > > Committed: https://crrev.com/b1963b403f8e9258c35a02d2622da254cbb90c51 > Cr-Commit-Position: refs/heads/master@{#13132} TBR=henrik.lundin@webrtc.org,minyue@webrtc.org BUG=webrtc:5530 NOTRY=true Committed: https://crrev.com/4867ca2689d6576a750180b8f8e6bd9a9e23056f Cr-Commit-Position: refs/heads/master@{#13169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M tools/ubsan/blacklist.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/agc/legacy/analog_agc.c View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/agc/legacy/digital_agc.c View 2 chunks +8 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pbos-webrtc
Created Revert of -enable UBsan on AGC.
4 years, 6 months ago (2016-06-16 14:50:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078433003/1
4 years, 6 months ago (2016-06-16 14:51:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 14:59:13 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 14:59:16 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4867ca2689d6576a750180b8f8e6bd9a9e23056f Cr-Commit-Position: refs/heads/master@{#13169}
4 years, 6 months ago (2016-06-16 14:59:19 UTC) #9
hlundin-webrtc
4 years, 6 months ago (2016-06-17 10:38:02 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698