Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2077883002: GN: Update xmpp and p2p to match Chromium build (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Update xmpp and p2p to match Chromium build Manual review shows that several more sources should be excluded for the Chromium build. This is likely what's blocking https://codereview.chromium.org/2022833002/ It was also discovered that the following were missing from GYP+GN: webrtc/p2p/base/dtlstransport.h webrtc/p2p/base/session.cc webrtc/p2p/base/session.h BUG=webrtc:4256 TBR=pthatcher@webrtc.org NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/5023d41cb4c8816bcf9d4283c7bb5471a3ba93b3 Cr-Commit-Position: refs/heads/master@{#13200}

Patch Set 1 #

Patch Set 2 : Added nacl dependency and missing sources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -110 lines) Patch
M webrtc/libjingle/xmpp/BUILD.gn View 1 3 chunks +56 lines, -49 lines 0 comments Download
M webrtc/libjingle/xmpp/xmpp.gyp View 3 chunks +50 lines, -48 lines 0 comments Download
M webrtc/p2p/BUILD.gn View 1 5 chunks +16 lines, -7 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 5 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
kjellander_webrtc
TBRing this to make some progress on this multi-step rocket
4 years, 6 months ago (2016-06-18 10:36:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077883002/20001
4 years, 6 months ago (2016-06-18 10:38:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6392)
4 years, 6 months ago (2016-06-18 10:48:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077883002/20001
4 years, 6 months ago (2016-06-18 11:22:56 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-18 11:23:06 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-18 11:23:15 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5023d41cb4c8816bcf9d4283c7bb5471a3ba93b3
Cr-Commit-Position: refs/heads/master@{#13200}

Powered by Google App Engine
This is Rietveld 408576698