Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2077823002: Fix missing resource file in webrtc_perf_tests.isolate (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix missing resource file in webrtc_perf_tests.isolate In https://codereview.webrtc.org/2074043002/ the Chromium test framework for Android started cleaning up resources between runs to prevent old resources file polluting test runs. This surfaced that one file was missing in the webrtc_perf_tests.isolate list. TBR=henrik.lundin@webrtc.org NOTRY=True Committed: https://crrev.com/50c4821110469315fcd79e3029bfb091dba74cea Cr-Commit-Position: refs/heads/master@{#13180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/webrtc_perf_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kjellander_webrtc
TBRing based no https://build.chromium.org/p/client.webrtc/builders/Android64%20Tests%20%28L%20Nexus9%29/builds/3728/steps/webrtc_perf_tests/logs/stdio and the error: [ RUN ] NetEqPerformanceTest.Run I 585.949s run_tests_on_device(HT4ADJT03192) (neteq_impl.cc:114): ...
4 years, 6 months ago (2016-06-17 07:32:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077823002/1
4 years, 6 months ago (2016-06-17 07:32:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 07:39:45 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/50c4821110469315fcd79e3029bfb091dba74cea Cr-Commit-Position: refs/heads/master@{#13180}
4 years, 6 months ago (2016-06-17 07:39:58 UTC) #10
hlundin-webrtc
4 years, 6 months ago (2016-06-17 10:40:32 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698