webrtc/examples/androidapp/res/values/arrays.xml - Issue 2077663003: Camera2 in AppRTC Android Demo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/examples/androidapp/res/values/arrays.xml

Issue 2077663003: Camera2 in AppRTC Android Demo. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@camera2_only

Patch Set: Rebase. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <resources>	2 <resources>

	3 <string-array name="enableDisableForce">
	magjed_webrtc 2016/06/29 13:36:44 This name looks weird. Shouldn't at least 'camera2 This name looks weird. Shouldn't at least 'camera2' be included, e.g. 'camera2Values'? sakal 2016/06/30 09:14:52 Done. Show quoted text On 2016/06/29 13:36:44, magjed_webrtc wrote: > This name looks weird. Shouldn't at least 'camera2' be included, e.g. > 'camera2Values'? Done.
	4 <item>Enable</item>
	magjed_webrtc 2016/06/29 13:36:45 I think you should go with 'Default', 'True', 'Fal I think you should go with 'Default', 'True', 'False' for consistency with the rest of the code. sakal 2016/06/30 09:14:52 Done. Show quoted text On 2016/06/29 13:36:45, magjed_webrtc wrote: > I think you should go with 'Default', 'True', 'False' for consistency with the > rest of the code. Done.
	5 <item>Disable</item>

	6 <item>Force enable</item>

	7 </string-array>

	8

	9 <string-array name="enableDisableForceValues">

	10 <item>true</item>

	11 <item>false</item>

	12 <item>force</item>

	13 </string-array>

	14

3 <string-array name="videoResolutions">	15 <string-array name="videoResolutions">

4 <item>Default</item>	16 <item>Default</item>

5 <item>HD (1280 x 720)</item>	17 <item>HD (1280 x 720)</item>

6 <item>VGA (640 x 480)</item>	18 <item>VGA (640 x 480)</item>

7 <item>QVGA (320 x 240)</item>	19 <item>QVGA (320 x 240)</item>

8 </string-array>	20 </string-array>

9	21

10 <string-array name="videoResolutionsValues">	22 <string-array name="videoResolutionsValues">

11 <item>Default</item>	23 <item>Default</item>

12 <item>1280 x 720</item>	24 <item>1280 x 720</item>

(...skipping 21 matching lines...) Expand all Loading...
34 <string-array name="audioCodecs">	46 <string-array name="audioCodecs">

35 <item>OPUS</item>	47 <item>OPUS</item>

36 <item>ISAC</item>	48 <item>ISAC</item>

37 </string-array>	49 </string-array>

38	50

39 <string-array name="roomListContextMenu">	51 <string-array name="roomListContextMenu">

40 <item>Remove favorite</item>	52 <item>Remove favorite</item>

41 </string-array>	53 </string-array>

42	54

43 </resources>	55 </resources>

OLD	NEW

« no previous file with comments | « no previous file | webrtc/examples/androidapp/res/values/strings.xml » ('j') | webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java » ('J')