Use QualityScaler for OpenH264 encoder.

Use QualityScaler for OpenH264 encoder.

BUG=
R=sprang@webrtc.org

Committed: https://crrev.com/6d3e0c22c31bab111be833d598eea6118dfe0e83
Cr-Commit-Position: refs/heads/master@{#13222}

[pbos-webrtc, 2016-06-20 15:54:14]

Description was changed from

==========
Use QualityScaler for OpenH264 encoder.

BUG=
==========

to

==========
Use QualityScaler for OpenH264 encoder.

BUG=
R=sprang@webrtc.org
==========

[pbos-webrtc, 2016-06-20 15:54:14]

pbos@webrtc.org changed reviewers:
+ sprang@webrtc.org

[pbos-webrtc, 2016-06-20 15:54:23]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 15:54:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077393003/1

[pbos-webrtc, 2016-06-20 15:55:02]

PTAL

[commit-bot: I haz the power, 2016-06-20 16:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 16:25:18]

Dry run: This issue passed the CQ dry run.

[sprang_webrtc, 2016-06-20 18:29:37]

looks good, but I'd welcome a unit test of some kind.

https://codereview.webrtc.org/2077393003/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc (right):

https://codereview.webrtc.org/2077393003/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc:393: // in
InitializeExt.
nit: Why are these called init params, rather than say EncoderParams? The struct
name is EncParamsBase, and the method to use them SetOptions.

[pbos-webrtc, 2016-06-20 18:39:10]

call them EncoderParams

[pbos-webrtc, 2016-06-20 18:42:18]

call them encoder_params

[pbos-webrtc, 2016-06-20 18:42:58]

PTAL, the tests would better be added when all QualityScaler usage moves outside
encoder implementation, testing right now is very tricky.

[sprang_webrtc, 2016-06-20 18:45:29]

ack
lgtm

[pbos-webrtc, 2016-06-20 18:49:49]

Description was changed from

==========
Use QualityScaler for OpenH264 encoder.

BUG=
R=sprang@webrtc.org
==========

to

==========
Use QualityScaler for OpenH264 encoder.

BUG=
R=sprang@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/6d3e0c22c31bab111be833d59...
==========

[pbos-webrtc, 2016-06-20 18:49:50]

Committed patchset #3 (id:40001) manually as
6d3e0c22c31bab111be833d598eea6118dfe0e83 (presubmit successful).

[commit-bot: I haz the power, 2016-06-20 18:49:51]

Description was changed from

==========
Use QualityScaler for OpenH264 encoder.

BUG=
R=sprang@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/6d3e0c22c31bab111be833d59...
==========

to

==========
Use QualityScaler for OpenH264 encoder.

BUG=
R=sprang@webrtc.org

Committed: https://crrev.com/6d3e0c22c31bab111be833d598eea6118dfe0e83
Cr-Commit-Position: refs/heads/master@{#13222}
==========