Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2076513002: Fix a few error prone lines on VideoCapturerAndroid. (Closed)

Created:
4 years, 6 months ago by sakal
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a few error prone lines on VideoCapturerAndroid. R=pbos@webrtc.org, perkj@webrtc.org Committed: https://crrev.com/5a9e7e0ba0a0b68b51885f9e441f308399d15c6a Cr-Commit-Position: refs/heads/master@{#13164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
sakal
PTAL
4 years, 6 months ago (2016-06-16 12:12:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076513002/1
4 years, 6 months ago (2016-06-16 12:12:33 UTC) #4
pbos-webrtc
rs-lgtm
4 years, 6 months ago (2016-06-16 12:12:35 UTC) #5
perkj_webrtc
lgtm
4 years, 6 months ago (2016-06-16 12:17:12 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5a9e7e0ba0a0b68b51885f9e441f308399d15c6a Cr-Commit-Position: refs/heads/master@{#13164}
4 years, 6 months ago (2016-06-16 12:26:09 UTC) #10
sakal
4 years, 6 months ago (2016-06-16 12:26:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a9e7e0ba0a0b68b51885f9e441f308399d15c6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698