Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2076123002: Reland of Delete unused and almost unused frame-related methods. (Closed)

Created:
4 years, 6 months ago by nisse-webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Partial reland of Delete unused and almost unused frame-related methods. (patchset #1 id:1 of https://codereview.webrtc.org/2076113002/ ) Reason for revert: Taking out the VideoFrameBuffer changes which broke downstream. Original issue's description: > Revert of Delete unused and almost unused frame-related methods. (patchset #12 id:220001 of https://codereview.webrtc.org/2065733003/ ) > > Reason for revert: > Breaks downstream applications which inherits webrtc::VideoFrameBuffer and tries to override deleted methods data(), stride() and MutableData(). > > Original issue's description: > > Delete unused and almost unused frame-related methods. > > > > webrtc::VideoFrame::set_video_frame_buffer > > webrtc::VideoFrame::ConvertNativeToI420Frame > > > > cricket::WebRtcVideoFrame::InitToBlack > > > > VideoFrameBuffer::data > > VideoFrameBuffer::stride > > VideoFrameBuffer::MutableData > > > > TBR=tkchin@webrtc.org # Refactoring affecting RTCVideoFrame > > BUG=webrtc:5682 > > > > Committed: https://crrev.com/76270de4bc2dac188f10f805e6e2fb86693ef864 > > Cr-Commit-Position: refs/heads/master@{#13183} > > TBR=perkj@webrtc.org,pbos@webrtc.org,marpan@webrtc.org,tkchin@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5682 > > Committed: https://crrev.com/72e735d3867a0fd6ab7e4d0761c7ba5f6c068617 > Cr-Commit-Position: refs/heads/master@{#13184} TBR=perkj@webrtc.org,pbos@webrtc.org,marpan@webrtc.org,tkchin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/ca6d5d1c9fd1b16368c2bbb32366ec32f1caa9db Cr-Commit-Position: refs/heads/master@{#13189}

Patch Set 1 #

Patch Set 2 : Revert changes to VideoFrameBuffer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -99 lines) Patch
M webrtc/api/java/jni/androidmediadecoder_jni.cc View 1 2 chunks +12 lines, -12 lines 0 comments Download
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 1 2 chunks +13 lines, -11 lines 0 comments Download
M webrtc/api/java/jni/androidvideocapturer_jni.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_video/corevideo_frame_buffer.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc View 1 2 chunks +20 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 1 1 chunk +11 lines, -3 lines 0 comments Download
M webrtc/modules/video_processing/frame_preprocessor.cc View 1 1 chunk +11 lines, -8 lines 0 comments Download
M webrtc/modules/video_processing/spatial_resampler.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoFrame.mm View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/video_frame.h View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
nisse-webrtc
Created Reland of Delete unused and almost unused frame-related methods.
4 years, 6 months ago (2016-06-17 10:18:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076123002/270001
4 years, 6 months ago (2016-06-17 10:55:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 10:55:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076123002/270001
4 years, 6 months ago (2016-06-17 12:02:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:270001)
4 years, 6 months ago (2016-06-17 12:03:08 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 12:03:13 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca6d5d1c9fd1b16368c2bbb32366ec32f1caa9db
Cr-Commit-Position: refs/heads/master@{#13189}

Powered by Google App Engine
This is Rietveld 408576698