Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2076113002: Revert of Delete unused and almost unused frame-related methods. (Closed)

Created:
4 years, 6 months ago by nisse-webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete unused and almost unused frame-related methods. (patchset #12 id:220001 of https://codereview.webrtc.org/2065733003/ ) Reason for revert: Breaks downstream applications which inherits webrtc::VideoFrameBuffer and tries to override deleted methods data(), stride() and MutableData(). Original issue's description: > Delete unused and almost unused frame-related methods. > > webrtc::VideoFrame::set_video_frame_buffer > webrtc::VideoFrame::ConvertNativeToI420Frame > > cricket::WebRtcVideoFrame::InitToBlack > > VideoFrameBuffer::data > VideoFrameBuffer::stride > VideoFrameBuffer::MutableData > > TBR=tkchin@webrtc.org # Refactoring affecting RTCVideoFrame > BUG=webrtc:5682 > > Committed: https://crrev.com/76270de4bc2dac188f10f805e6e2fb86693ef864 > Cr-Commit-Position: refs/heads/master@{#13183} TBR=perkj@webrtc.org,pbos@webrtc.org,marpan@webrtc.org,tkchin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/72e735d3867a0fd6ab7e4d0761c7ba5f6c068617 Cr-Commit-Position: refs/heads/master@{#13184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -93 lines) Patch
M webrtc/api/java/jni/androidmediadecoder_jni.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 2 chunks +11 lines, -13 lines 0 comments Download
M webrtc/api/java/jni/androidvideocapturer_jni.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_video/corevideo_frame_buffer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_video/include/video_frame_buffer.h View 1 chunk +13 lines, -6 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M webrtc/common_video/video_frame_buffer.cc View 2 chunks +62 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc View 2 chunks +8 lines, -21 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M webrtc/modules/video_processing/frame_preprocessor.cc View 1 chunk +8 lines, -11 lines 0 comments Download
M webrtc/modules/video_processing/spatial_resampler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoFrame.mm View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/video_frame.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nisse-webrtc
Created Revert of Delete unused and almost unused frame-related methods.
4 years, 6 months ago (2016-06-17 09:54:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076113002/1
4 years, 6 months ago (2016-06-17 09:55:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 09:55:19 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/72e735d3867a0fd6ab7e4d0761c7ba5f6c068617 Cr-Commit-Position: refs/heads/master@{#13184}
4 years, 6 months ago (2016-06-17 09:55:33 UTC) #6
nisse-webrtc
4 years, 6 months ago (2016-06-17 10:18:30 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2076123002/ by nisse@webrtc.org.

The reason for reverting is: Planning to reland, with the video_frame_buffer
changes taken out..

Powered by Google App Engine
This is Rietveld 408576698