Cleanups in cricket::VideoFrame and cricket::WebRtcVideoFrame.

webrtc/media/engine/webrtcvideoframe_unittest.cc

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <string.h>
 
 #include <memory>
 
 #include "webrtc/media/base/videoframe_unittest.h"
 #include "webrtc/media/engine/webrtcvideoframe.h"
 #include "webrtc/test/fake_texture_frame.h"
 
-namespace {
+namespace cricket {
 
-class WebRtcVideoTestFrame : public cricket::WebRtcVideoFrame {
+class WebRtcVideoFrameTest : public VideoFrameTest<WebRtcVideoFrame> {
  public:
-  WebRtcVideoTestFrame() {}
-  WebRtcVideoTestFrame(
-      const rtc::scoped_refptr<webrtc::VideoFrameBuffer>& buffer,
-      int64_t time_stamp_ns,
-      webrtc::VideoRotation rotation)
-    : WebRtcVideoFrame(buffer, time_stamp_ns, rotation) {}
-
-  // The ApplyRotationToFrame test needs this as a public method.
-  using cricket::WebRtcVideoFrame::set_rotation;
-
-  virtual VideoFrame* CreateEmptyFrame(int w,
-                                       int h,
-                                       int64_t time_stamp) const override {
-    rtc::scoped_refptr<webrtc::I420Buffer> buffer(
-        new rtc::RefCountedObject<webrtc::I420Buffer>(w, h));
-    buffer->SetToBlack();
-    return new WebRtcVideoTestFrame(
-        buffer, time_stamp, webrtc::kVideoRotation_0);
-  }
-};
-
-}  // namespace
-
-class WebRtcVideoFrameTest : public VideoFrameTest<cricket::WebRtcVideoFrame> {
- public:
-  WebRtcVideoFrameTest() {
-  }
+  WebRtcVideoFrameTest() {}
 
   void TestInit(int cropped_width, int cropped_height,
                 webrtc::VideoRotation frame_rotation,
                 bool apply_rotation) {
     const int frame_width = 1920;
     const int frame_height = 1080;
 
     // Build the CapturedFrame.
-    cricket::CapturedFrame captured_frame;
-    captured_frame.fourcc = cricket::FOURCC_I420;
+    CapturedFrame captured_frame;
+    captured_frame.fourcc = FOURCC_I420;
     captured_frame.time_stamp = rtc::TimeNanos();
     captured_frame.rotation = frame_rotation;
     captured_frame.width = frame_width;
     captured_frame.height = frame_height;
     captured_frame.data_size = (frame_width * frame_height) +
         ((frame_width + 1) / 2) * ((frame_height + 1) / 2) * 2;
     std::unique_ptr<uint8_t[]> captured_frame_buffer(
         new uint8_t[captured_frame.data_size]);
     // Initialize memory to satisfy DrMemory tests.
     memset(captured_frame_buffer.get(), 0, captured_frame.data_size);
     captured_frame.data = captured_frame_buffer.get();
 
     // Create the new frame from the CapturedFrame.
-    cricket::WebRtcVideoFrame frame;
+    WebRtcVideoFrame frame;
     EXPECT_TRUE(
         frame.Init(&captured_frame, cropped_width, cropped_height,
                    apply_rotation));
 
     // Verify the new frame.
     EXPECT_EQ(captured_frame.time_stamp / rtc::kNumNanosecsPerMicrosec,
               frame.timestamp_us());
     if (apply_rotation)
       EXPECT_EQ(webrtc::kVideoRotation_0, frame.rotation());
     else
       EXPECT_EQ(frame_rotation, frame.rotation());
     // If |apply_rotation| and the frame rotation is 90 or 270, width and
     // height are flipped.
     if (apply_rotation && (frame_rotation == webrtc::kVideoRotation_90
         || frame_rotation == webrtc::kVideoRotation_270)) {
       EXPECT_EQ(cropped_width, frame.height());
       EXPECT_EQ(cropped_height, frame.width());
     } else {
       EXPECT_EQ(cropped_width, frame.width());
       EXPECT_EQ(cropped_height, frame.height());
     }
   }
+
+  void SetFrameRotation(WebRtcVideoFrame* frame,
+                        webrtc::VideoRotation rotation) {
+    frame->rotation_ = rotation;
+  }
 };
 
-#define TEST_WEBRTCVIDEOFRAME(X) TEST_F(WebRtcVideoFrameTest, X) { \
-  VideoFrameTest<cricket::WebRtcVideoFrame>::X(); \
-}
+#define TEST_WEBRTCVIDEOFRAME(X) \
+  TEST_F(WebRtcVideoFrameTest, X) { VideoFrameTest<WebRtcVideoFrame>::X(); }
 
 TEST_WEBRTCVIDEOFRAME(ConstructI420)
 TEST_WEBRTCVIDEOFRAME(ConstructI422)
 TEST_WEBRTCVIDEOFRAME(ConstructYuy2)
 TEST_WEBRTCVIDEOFRAME(ConstructYuy2Unaligned)
 TEST_WEBRTCVIDEOFRAME(ConstructYuy2Wide)
 TEST_WEBRTCVIDEOFRAME(ConstructYV12)
 TEST_WEBRTCVIDEOFRAME(ConstructUyvy)
 TEST_WEBRTCVIDEOFRAME(ConstructM420)
 TEST_WEBRTCVIDEOFRAME(ConstructNV21)
@@ skipping 163 matching lines @@
   TestInit(640, 360, webrtc::kVideoRotation_90, false);
 }
 
 TEST_F(WebRtcVideoFrameTest, TextureInitialValues) {
   webrtc::test::FakeNativeHandle* dummy_handle =
       new webrtc::test::FakeNativeHandle();
   webrtc::NativeHandleBuffer* buffer =
       new rtc::RefCountedObject<webrtc::test::FakeNativeHandleBuffer>(
           dummy_handle, 640, 480);
   // Timestamp is converted from ns to us, so last three digits are lost.
-  cricket::WebRtcVideoFrame frame(buffer, 20000, webrtc::kVideoRotation_0);
+  WebRtcVideoFrame frame(buffer, 20000, webrtc::kVideoRotation_0);
   EXPECT_EQ(dummy_handle, frame.video_frame_buffer()->native_handle());
   EXPECT_EQ(640, frame.width());
   EXPECT_EQ(480, frame.height());
   EXPECT_EQ(20000, frame.GetTimeStamp());
   EXPECT_EQ(20, frame.timestamp_us());
   frame.set_timestamp_us(40);
   EXPECT_EQ(40000, frame.GetTimeStamp());
   EXPECT_EQ(40, frame.timestamp_us());
 }
 
 TEST_F(WebRtcVideoFrameTest, CopyTextureFrame) {
   webrtc::test::FakeNativeHandle* dummy_handle =
       new webrtc::test::FakeNativeHandle();
   webrtc::NativeHandleBuffer* buffer =
       new rtc::RefCountedObject<webrtc::test::FakeNativeHandleBuffer>(
           dummy_handle, 640, 480);
   // Timestamp is converted from ns to us, so last three digits are lost.
-  cricket::WebRtcVideoFrame frame1(buffer, 20000, webrtc::kVideoRotation_0);
-  cricket::VideoFrame* frame2 = frame1.Copy();
+  WebRtcVideoFrame frame1(buffer, 20000, webrtc::kVideoRotation_0);
+  VideoFrame* frame2 = frame1.Copy();
   EXPECT_EQ(frame1.video_frame_buffer()->native_handle(),
             frame2->video_frame_buffer()->native_handle());
   EXPECT_EQ(frame1.width(), frame2->width());
   EXPECT_EQ(frame1.height(), frame2->height());
   EXPECT_EQ(frame1.GetTimeStamp(), frame2->GetTimeStamp());
   EXPECT_EQ(frame1.timestamp_us(), frame2->timestamp_us());
   delete frame2;
 }
 
 TEST_F(WebRtcVideoFrameTest, ApplyRotationToFrame) {
-  WebRtcVideoTestFrame applied0;
+  WebRtcVideoFrame applied0;
   EXPECT_TRUE(IsNull(applied0));
-  EXPECT_TRUE(LoadFrame(CreateYuvSample(kWidth, kHeight, 12).get(),
-                        cricket::FOURCC_I420, kWidth, kHeight, &applied0));
+  EXPECT_TRUE(LoadFrame(CreateYuvSample(kWidth, kHeight, 12).get(), FOURCC_I420,
+                        kWidth, kHeight, &applied0));
 
   // Claim that this frame needs to be rotated for 90 degree.
-  applied0.set_rotation(webrtc::kVideoRotation_90);
+  SetFrameRotation(&applied0, webrtc::kVideoRotation_90);
 
   // Apply rotation on frame 1. Output should be different from frame 1.
-  WebRtcVideoTestFrame* applied90 = const_cast<WebRtcVideoTestFrame*>(
-      static_cast<const WebRtcVideoTestFrame*>(
+  WebRtcVideoFrame* applied90 =
+      const_cast<WebRtcVideoFrame*>(static_cast<const WebRtcVideoFrame*>(
           applied0.GetCopyWithRotationApplied()));
   EXPECT_TRUE(applied90);
   EXPECT_EQ(applied90->rotation(), webrtc::kVideoRotation_0);
   EXPECT_FALSE(IsEqual(applied0, *applied90, 0));
 
   // Claim the frame 2 needs to be rotated for another 270 degree. The output
   // from frame 2 rotation should be the same as frame 1.
-  applied90->set_rotation(webrtc::kVideoRotation_270);
-  const cricket::VideoFrame* applied360 =
-      applied90->GetCopyWithRotationApplied();
+  SetFrameRotation(applied90, webrtc::kVideoRotation_270);
+  const VideoFrame* applied360 = applied90->GetCopyWithRotationApplied();
   EXPECT_TRUE(applied360);
   EXPECT_EQ(applied360->rotation(), webrtc::kVideoRotation_0);
   EXPECT_TRUE(IsEqual(applied0, *applied360, 0));
 }
+
+}  // namespace cricket