Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2074763002: Revert of Fix crash parsing malformed rtp packet (Closed)

Created:
4 years, 6 months ago by danilchap
Modified:
4 years, 6 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix crash parsing malformed rtp packet (patchset #1 id:1 of https://codereview.webrtc.org/2067793003/ ) Reason for revert: breaks Win64 bots compile Original issue's description: > Fix crash parsing malformed rtp packet > where header extesnsion size mismatch expected. > > BUG=chromium:620242 > R=asapersson@webrtc.org > > Committed: https://crrev.com/5a45fe6fd7a509fb4c3a9b09cdbd2278055f1d4c > Cr-Commit-Position: refs/heads/master@{#13170} TBR=asapersson@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:620242 Committed: https://crrev.com/e565a04de3d28e6530a2599e6b90bb9fb5748185 Cr-Commit-Position: refs/heads/master@{#13171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -39 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc View 3 chunks +1 line, -32 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danilchap
Created Revert of Fix crash parsing malformed rtp packet
4 years, 6 months ago (2016-06-16 17:04:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074763002/1
4 years, 6 months ago (2016-06-16 17:04:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 17:04:56 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 17:04:58 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 17:05:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e565a04de3d28e6530a2599e6b90bb9fb5748185
Cr-Commit-Position: refs/heads/master@{#13171}

Powered by Google App Engine
This is Rietveld 408576698