Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Unified Diff: webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc

Issue 2072753002: WebRtcVoiceEngine: Use AudioDecoderFactory to generate recv codecs. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed tommi's comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/media.gyp ('k') | webrtc/modules/audio_coding/codecs/mock/mock_audio_decoder_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc
diff --git a/webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc b/webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc
index 48b2f5d437312de30531837bda4c34fb9ca04732..a7f740489210686894105159cb103d1c25b9c5bb 100644
--- a/webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc
+++ b/webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc
@@ -130,7 +130,31 @@ NamedDecoderConstructor decoder_constructors[] = {
class BuiltinAudioDecoderFactory : public AudioDecoderFactory {
public:
std::vector<SdpAudioFormat> GetSupportedFormats() override {
- FATAL() << "Not implemented yet!";
+ static std::vector<SdpAudioFormat> formats = {
+#ifdef WEBRTC_CODEC_OPUS
+ { "opus", 48000, 2, {
+ {"minptime", "10" },
+ {"useinbandfec", "1" }
+ }
+ },
+#endif
+#if (defined(WEBRTC_CODEC_ISAC) || defined(WEBRTC_CODEC_ISACFX))
+ { "isac", 16000, 1 },
+#endif
+#if (defined(WEBRTC_CODEC_ISAC))
+ { "isac", 32000, 1 },
+#endif
+#ifdef WEBRTC_CODEC_G722
+ { "G722", 8000, 1 },
+#endif
+#ifdef WEBRTC_CODEC_ILBC
+ { "iLBC", 8000, 1 },
+#endif
+ { "PCMU", 8000, 1 },
+ { "PCMA", 8000, 1 }
+ };
+
+ return formats;
}
std::unique_ptr<AudioDecoder> MakeAudioDecoder(
« no previous file with comments | « webrtc/media/media.gyp ('k') | webrtc/modules/audio_coding/codecs/mock/mock_audio_decoder_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698