Chromium Code Reviews

Issue 2072033004: Reland of Re-enable UBsan on AGC. (Closed)

Created:
4 years, 6 months ago by minyue-webrtc
Modified:
4 years, 6 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Re-enable UBsan on AGC. patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/ This reverts commit 4867ca2689d6576a750180b8f8e6bd9a9e23056f. BUG=webrtc:5530 TBR=peah@webrtc.org, kjellander@webrtc.org Committed: https://crrev.com/fd634c43e964ad03ab7463f2b9c642c26102bca1 Cr-Commit-Position: refs/heads/master@{#13188}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+17 lines, -25 lines)
M tools/ubsan/blacklist.txt View 1 chunk +0 lines, -6 lines 0 comments
M webrtc/modules/audio_processing/agc/legacy/analog_agc.c View 1 chunk +3 lines, -3 lines 0 comments
M webrtc/modules/audio_processing/agc/legacy/digital_agc.c View 2 chunks +6 lines, -8 lines 0 comments
M webrtc/modules/audio_processing/gain_control_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments

Messages

Total messages: 14 (7 generated)
minyue-webrtc
Another blocker was found. (interesting that it was not found last time). It has been ...
4 years, 6 months ago (2016-06-17 08:41:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072033004/1
4 years, 6 months ago (2016-06-17 08:41:36 UTC) #5
hlundin-webrtc
lgtm
4 years, 6 months ago (2016-06-17 10:39:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 6 months ago (2016-06-17 10:42:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072033004/1
4 years, 6 months ago (2016-06-17 10:44:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 11:36:14 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 11:36:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd634c43e964ad03ab7463f2b9c642c26102bca1
Cr-Commit-Position: refs/heads/master@{#13188}

Powered by Google App Engine