Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 2071473002: Reland of Split IncomingVideoStream into two implementations, with smoothing and without. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: add explicit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index c8c122a97b4bb5100f5346c56f6bd450c70c5998..cc50eefe2804259427353fccc430810d1177d23e 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -2027,7 +2027,8 @@ TEST_F(EndToEndTest, VerifyNackStats) {
void EndToEndTest::VerifyHistogramStats(bool use_rtx,
bool use_red,
bool screenshare) {
- class StatsObserver : public test::EndToEndTest {
+ class StatsObserver : public test::EndToEndTest,
+ public rtc::VideoSinkInterface<VideoFrame> {
public:
StatsObserver(bool use_rtx, bool use_red, bool screenshare)
: EndToEndTest(kLongTimeoutMs),
@@ -2043,6 +2044,8 @@ void EndToEndTest::VerifyHistogramStats(bool use_rtx,
start_runtime_ms_(-1) {}
private:
+ void OnFrame(const VideoFrame& video_frame) override {}
+
Action OnSendRtp(const uint8_t* packet, size_t length) override {
if (MinMetricRunTimePassed())
observation_complete_.Set();
@@ -2067,6 +2070,7 @@ void EndToEndTest::VerifyHistogramStats(bool use_rtx,
// NACK
send_config->rtp.nack.rtp_history_ms = kNackRtpHistoryMs;
(*receive_configs)[0].rtp.nack.rtp_history_ms = kNackRtpHistoryMs;
+ (*receive_configs)[0].renderer = this;
// FEC
if (use_red_) {
send_config->rtp.fec.ulpfec_payload_type = kUlpfecPayloadType;
@@ -2490,6 +2494,15 @@ TEST_F(EndToEndTest, ReportsSetEncoderRates) {
TEST_F(EndToEndTest, GetStats) {
static const int kStartBitrateBps = 3000000;
static const int kExpectedRenderDelayMs = 20;
+
+ class ReceiveStreamRenderer : public rtc::VideoSinkInterface<VideoFrame> {
+ public:
+ ReceiveStreamRenderer() {}
+
+ private:
+ void OnFrame(const VideoFrame& video_frame) override {}
+ };
+
class StatsObserver : public test::EndToEndTest,
public rtc::VideoSinkInterface<VideoFrame> {
public:
@@ -2690,6 +2703,7 @@ TEST_F(EndToEndTest, GetStats) {
expected_receive_ssrcs_.push_back(
(*receive_configs)[i].rtp.remote_ssrc);
(*receive_configs)[i].render_delay_ms = kExpectedRenderDelayMs;
+ (*receive_configs)[i].renderer = &receive_stream_renderer_;
}
// Use a delayed encoder to make sure we see CpuOveruseMetrics stats that
// are non-zero.
@@ -2759,6 +2773,7 @@ TEST_F(EndToEndTest, GetStats) {
std::string expected_cname_;
rtc::Event check_stats_event_;
+ ReceiveStreamRenderer receive_stream_renderer_;
} test;
RunBaseTest(&test);
« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc ('k') | webrtc/video/video_receive_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698