Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1838)

Unified Diff: webrtc/common_video/video_render_frames.h

Issue 2071473002: Reland of Split IncomingVideoStream into two implementations, with smoothing and without. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: add explicit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/common_video/incoming_video_stream_unittest.cc ('k') | webrtc/common_video/video_render_frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_video/video_render_frames.h
diff --git a/webrtc/common_video/video_render_frames.h b/webrtc/common_video/video_render_frames.h
index acd955887f81405cd220e997348c92d0d58f9c90..26a7ef5137438ac336a1cbe319668558e3d7c624 100644
--- a/webrtc/common_video/video_render_frames.h
+++ b/webrtc/common_video/video_render_frames.h
@@ -23,7 +23,8 @@ namespace webrtc {
// Class definitions
class VideoRenderFrames {
public:
- VideoRenderFrames();
+ explicit VideoRenderFrames(uint32_t render_delay_ms);
+ VideoRenderFrames(const VideoRenderFrames&) = delete;
// Add a frame to the render queue
int32_t AddFrame(const VideoFrame& new_frame);
@@ -31,15 +32,9 @@ class VideoRenderFrames {
// Get a frame for rendering, or false if it's not time to render.
rtc::Optional<VideoFrame> FrameToRender();
- // Releases all frames
- int32_t ReleaseAllFrames();
-
// Returns the number of ms to next frame to render
uint32_t TimeToNextFrameRelease();
- // Sets estimates delay in renderer
- int32_t SetRenderDelay(const uint32_t render_delay);
-
private:
// 10 seconds for 30 fps.
enum { KMaxNumberOfFrames = 300 };
@@ -52,7 +47,7 @@ class VideoRenderFrames {
std::list<VideoFrame> incoming_frames_;
// Estimated delay from a frame is released until it's rendered.
- uint32_t render_delay_ms_;
+ const uint32_t render_delay_ms_;
};
} // namespace webrtc
« no previous file with comments | « webrtc/common_video/incoming_video_stream_unittest.cc ('k') | webrtc/common_video/video_render_frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698