Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 2070833002: Added a builtin audio decoder factory to the default PeerConnectionFactory constructor. (Closed)

Created:
4 years, 6 months ago by ossu
Modified:
4 years, 6 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added a builtin audio decoder factory to the default PeerConnectionFactory constructor. BUG=webrtc:5805 Committed: https://crrev.com/9b99499124792e5eb9342e670380d67d45f39e59 Cr-Commit-Position: refs/heads/master@{#13186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/api/peerconnectionfactory.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
ossu
I'm not sure if anyone is properly using PeerConnectionFactory like this, but it would probably ...
4 years, 6 months ago (2016-06-16 15:22:22 UTC) #3
kwiberg-webrtc
lgtm This looks like it makes sense. Too bad there isn't a std::unique_ref or something, ...
4 years, 6 months ago (2016-06-17 07:23:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070833002/1
4 years, 6 months ago (2016-06-17 11:12:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 11:16:28 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 11:16:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b99499124792e5eb9342e670380d67d45f39e59
Cr-Commit-Position: refs/heads/master@{#13186}

Powered by Google App Engine
This is Rietveld 408576698