Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1797)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc

Issue 2070673002: Test RtcpParser rewritten to use rtcp packet classes (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: reinterpret_cast -> static_cast Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
index acbe56c29257f04988765d98a50b1de26fa36aee..dfd928c8e268edd4ec6ea2f894bc610f491f65f9 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
@@ -79,15 +79,14 @@ class SendTransport : public Transport,
}
bool SendRtcp(const uint8_t* data, size_t len) override {
test::RtcpPacketParser parser;
- parser.Parse(static_cast<const uint8_t*>(data), len);
- last_nack_list_ = parser.nack_item()->last_nack_list();
+ parser.Parse(data, len);
+ last_nack_list_ = parser.nack()->packet_ids();
if (clock_) {
clock_->AdvanceTimeMilliseconds(delay_ms_);
}
- EXPECT_TRUE(receiver_ != NULL);
- EXPECT_EQ(0, receiver_->IncomingRtcpPacket(
- static_cast<const uint8_t*>(data), len));
+ EXPECT_TRUE(receiver_);
+ EXPECT_EQ(0, receiver_->IncomingRtcpPacket(data, len));
return true;
}
ModuleRtpRtcpImpl* receiver_;

Powered by Google App Engine
This is Rietveld 408576698