Remove ViEncoder::Pause / Start

webrtc/video/video_send_stream.h

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 120 matching lines @@
   static const bool kEnableFrameRecording = false;
   static const int kMaxLayers = 3;
   std::unique_ptr<IvfFileWriter> file_writers_[kMaxLayers];
 
   rtc::PlatformThread encoder_thread_;
   rtc::Event encoder_wakeup_event_;
   volatile int stop_encoder_thread_;
   rtc::CriticalSection encoder_settings_crit_;
   std::unique_ptr<EncoderSettings> pending_encoder_settings_
       GUARDED_BY(encoder_settings_crit_);
+
+  rtc::Optional<bool> pending_state_change_ GUARDED_BY(encoder_settings_crit_);

[pbos-webrtc, 2016/06/17 12:38:21]

Can you make this Optional<State> and just not use kEncoderTimedOut? It's hard
to read because if (*pending_state_change_) reads too close to "is there a state
change", not "what's the next state change". I think:

if (*pending_state_change == kStarted) is a lot easier to read.

[perkj_webrtc, 2016/06/17 13:06:32]

Done.

+
+  enum State {
+    kStopped,  // VideoSendStream::Start has not yet been called.
+    kStarted,  // VideoSendStream::Start has been called.
+    // VideoSendStream::Start has been called but the encoder have timed out.
+    kEncoderTimedOut,
+  };
+
   // Only used on the encoder thread.
-  bool send_stream_registered_as_observer_;
+  State state_;

[pbos-webrtc, 2016/06/17 12:38:21]

Can you make this GUARDED_BY a thread checker for the encoder thread then?

[perkj_webrtc, 2016/06/17 13:06:32]

Done.

+
   std::unique_ptr<EncoderSettings> current_encoder_settings_;
 
   OveruseFrameDetector overuse_detector_;
   ViEEncoder vie_encoder_;
   EncoderStateFeedback encoder_feedback_;
   ProtectionBitrateCalculator protection_bitrate_calculator_;
 
   vcm::VideoSender* const video_sender_;
 
   const std::unique_ptr<RtcpBandwidthObserver> bandwidth_observer_;
   // RtpRtcp modules, declared here as they use other members on construction.
   const std::vector<RtpRtcp*> rtp_rtcp_modules_;
   PayloadRouter payload_router_;
   VideoCaptureInput input_;
 };
 }  // namespace internal
 }  // namespace webrtc
 
 #endif  // WEBRTC_VIDEO_VIDEO_SEND_STREAM_H_