Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2069723003: Move AudioCodingModuleImpl to anonymous namespace in audio_coding_module.cc (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 6 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move AudioCodingModuleImpl to anonymous namespace in audio_coding_module.cc AudioCodingModuleImpl is the only implementation of the AudioCodingModule interface (except for test mocks). So it's a good fit to put it in an anonymous namespace in the interface's .cc file, to ensure that no one except AudioCodingModule::Create ever references it. Except for moving code, this CL introduces two other small changes: * It cleans up the set of #includes in audio_coding_module.cc. Specifically, I removed #includes that were already present in audio_coding_module.h, and did not bring along any #includes from audio_coding_module_impl.h and .cc except those that were necessary to get it to compile. * It moves AudioCodingModuleImpl from the webrtc::acm2 to the webrtc::<anonymous> namespace. This means I had to qualify a few things it references with acm2::. Committed: https://crrev.com/c13ded54ca8192fbd1286f8296e6f92326633ffa Cr-Commit-Position: refs/heads/master@{#13191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1224 lines, -1306 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver_unittest_oldapi.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 2 chunks +1223 lines, -5 lines 0 comments Download
D webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h View 1 chunk +0 lines, -311 lines 0 comments Download
D webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 1 chunk +0 lines, -984 lines 0 comments Download
M webrtc/modules/audio_coding/audio_coding.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 6 months ago (2016-06-16 02:36:50 UTC) #2
hlundin-webrtc
lgtm
4 years, 6 months ago (2016-06-17 10:36:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069723003/1
4 years, 6 months ago (2016-06-17 10:40:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 13:00:50 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 13:01:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c13ded54ca8192fbd1286f8296e6f92326633ffa
Cr-Commit-Position: refs/heads/master@{#13191}

Powered by Google App Engine
This is Rietveld 408576698