Do not switch best connection on the controlled side too frequently

webrtc/p2p/base/p2ptransportchannel.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 290 matching lines @@
 
   // |connections_| is a sorted list with the first one always be the
   // |best_connection_| when it's not nullptr. The combination of
   // |pinged_connections_| and |unpinged_connections_| has the same
   // connections as |connections_|. These 2 sets maintain whether a
   // connection should be pinged next or not.
   std::vector<Connection *> connections_;
   std::set<Connection*> pinged_connections_;
   std::set<Connection*> unpinged_connections_;
 
-  Connection* best_connection_;
+  Connection* best_connection_ = nullptr;

[pthatcher1, 2016/06/15 21:59:52]

Can we just start calling the "selected_connection_"?  The more we have
nominated vs. selected being different, the less "best" makes sense as a word.

[honghaiz3, 2016/06/16 23:03:48]

Done.

 
   // Connection selected by the controlling agent. This should be used only

[pthatcher1, 2016/06/15 21:59:52]

It should be "connection nominated by the controlling agent".

[honghaiz3, 2016/06/16 23:03:48]

Done.

   // at controlled side when protocol type is RFC5245.

[pthatcher1, 2016/06/15 21:59:52]

The stuff about protocol type is no longer needed.  GICE is gone.

[honghaiz3, 2016/06/16 23:03:48]

Done.

-  Connection* pending_best_connection_;
+  Connection* last_nominated_conn_ = nullptr;

[pthatcher1, 2016/06/15 21:59:52]

We could have it be "conn_" everwhere (including selected_connection_) or
"connection_" everywhere.  I'm fine either way.

[honghaiz3, 2016/06/16 23:03:48]

Done.

+  // The connection on which the data was received most recently.

[pthatcher1, 2016/06/15 21:59:52]

was most recently received.

[honghaiz3, 2016/06/16 23:03:48]

Done.

+  Connection* last_data_received_conn_ = nullptr;

[pthatcher1, 2016/06/15 21:59:52]

I think this should coincide with our "receiving" naming, so
"most_recently_receiving_conn_"

[honghaiz3, 2016/06/16 23:03:48]

Using last_receiving_connection_ as it is shorter and should have no confusion
with "most_recently..."

+
   std::vector<RemoteCandidate> remote_candidates_;
   bool sort_dirty_;  // indicates whether another sort is needed right now
   bool had_connection_ = false;  // if connections_ has ever been nonempty
   typedef std::map<rtc::Socket::Option, int> OptionMap;
   OptionMap options_;
   std::string ice_ufrag_;
   std::string ice_pwd_;
   std::vector<IceParameters> remote_ice_parameters_;
   IceMode remote_ice_mode_;
   IceRole ice_role_;
   uint64_t tiebreaker_;
   IceGatheringState gathering_state_;
 
   int check_receiving_interval_;
   int64_t last_ping_sent_ms_ = 0;
   int weak_ping_interval_ = WEAK_PING_INTERVAL;
   TransportChannelState state_ = TransportChannelState::STATE_INIT;
   IceConfig config_;
   int last_sent_packet_id_ = -1;  // -1 indicates no packet was sent before.
 
   RTC_DISALLOW_COPY_AND_ASSIGN(P2PTransportChannel);
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_P2P_BASE_P2PTRANSPORTCHANNEL_H_