Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2069103003: Add DesktopCapturer::Result::MAX_RESULT (Closed)

Created:
4 years, 6 months ago by Sergey Ulanov
Modified:
4 years, 6 months ago
Reviewers:
Jamie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add DesktopCapturer::Result::MAX_VALUE MAX_VALUE will be used in chromoting_messages.h to define range of valid DesktopCapturer::Result values. BUG=webrtc:5950 R=jamiewalch@chromium.org Committed: https://crrev.com/4c17abe35e0ffaea71dd3c2f5f67c3ddf49a6ef3 Cr-Commit-Position: refs/heads/master@{#13157}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/desktop_capture/desktop_capturer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Sergey Ulanov
4 years, 6 months ago (2016-06-15 20:18:59 UTC) #2
Jamie
lgtm
4 years, 6 months ago (2016-06-15 20:23:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069103003/20001
4 years, 6 months ago (2016-06-15 20:29:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/8736)
4 years, 6 months ago (2016-06-15 20:39:24 UTC) #9
Sergey Ulanov
4 years, 6 months ago (2016-06-15 20:56:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4c17abe35e0ffaea71dd3c2f5f67c3ddf49a6ef3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698