Chromium Code Reviews

Issue 2068463004: Remove EncodedFrameCallbackAdapter. (Closed)

Created:
4 years, 6 months ago by Sergey Ulanov
Modified:
4 years, 6 months ago
Reviewers:
pbos-webrtc, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman, asapersson1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove EncodedFrameCallbackAdapter. EncodedFrameCallbackAdapter was used VideoSendStream and VideoReceiveStream, but there is no reason to have it as these classes can call EncodedFrameObserver directly. Committed: https://crrev.com/37ad337848577dc6b56fb1cf0cb1a1d65c90aa6b Cr-Commit-Position: refs/heads/master@{#13145}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+9 lines, -91 lines)
M webrtc/video/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments
D webrtc/video/encoded_frame_callback_adapter.h View 1 chunk +0 lines, -36 lines 0 comments
D webrtc/video/encoded_frame_callback_adapter.cc View 1 chunk +0 lines, -39 lines 0 comments
M webrtc/video/video_receive_stream.h View 2 chunks +0 lines, -2 lines 0 comments
M webrtc/video/video_receive_stream.cc View 2 chunks +3 lines, -4 lines 0 comments
M webrtc/video/video_send_stream.h View 2 chunks +0 lines, -2 lines 0 comments
M webrtc/video/video_send_stream.cc View 2 chunks +6 lines, -4 lines 0 comments
M webrtc/video/webrtc_video.gypi View 1 chunk +0 lines, -2 lines 0 comments

Messages

Total messages: 9 (4 generated)
Sergey Ulanov
4 years, 6 months ago (2016-06-14 19:19:01 UTC) #2
pbos-webrtc
Agreed, lgtm. stefan@ is on vacation though. :)
4 years, 6 months ago (2016-06-14 19:20:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068463004/1
4 years, 6 months ago (2016-06-14 21:14:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 22:29:42 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 22:29:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37ad337848577dc6b56fb1cf0cb1a1d65c90aa6b
Cr-Commit-Position: refs/heads/master@{#13145}

Powered by Google App Engine