Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2068133002: Audio decoder factory test: Ensure that g722's sample rate is 16 kHz, not 8 kHz (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 6 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Audio decoder factory test: Ensure that g722's sample rate is 16 kHz, not 8 kHz Committed: https://crrev.com/ceb9d0cc290501403f268f06c0f779c8ea152f7a Cr-Commit-Position: refs/heads/master@{#13153}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kwiberg-webrtc
It's true: If tests aren't being run, they don't work...
4 years, 6 months ago (2016-06-15 11:36:36 UTC) #3
hlundin-webrtc
lgtm
4 years, 6 months ago (2016-06-15 12:48:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068133002/1
4 years, 6 months ago (2016-06-15 12:53:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 12:55:22 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 12:55:29 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ceb9d0cc290501403f268f06c0f779c8ea152f7a
Cr-Commit-Position: refs/heads/master@{#13153}

Powered by Google App Engine
This is Rietveld 408576698