Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2067793003: Fix crash parsing malformed rtp packet (Closed)

Created:
4 years, 6 months ago by danilchap
Modified:
4 years, 6 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix crash parsing malformed rtp packet where header extesnsion size mismatch expected. BUG=chromium:620242 R=asapersson@webrtc.org Committed: https://crrev.com/5a45fe6fd7a509fb4c3a9b09cdbd2278055f1d4c Cr-Commit-Position: refs/heads/master@{#13170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -5 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc View 3 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
åsapersson
lgtm
4 years, 6 months ago (2016-06-16 16:37:33 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5a45fe6fd7a509fb4c3a9b09cdbd2278055f1d4c Cr-Commit-Position: refs/heads/master@{#13170}
4 years, 6 months ago (2016-06-16 16:52:52 UTC) #6
danilchap
Committed patchset #1 (id:1) manually as 5a45fe6fd7a509fb4c3a9b09cdbd2278055f1d4c (presubmit successful).
4 years, 6 months ago (2016-06-16 16:52:53 UTC) #7
danilchap
4 years, 6 months ago (2016-06-16 17:04:34 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2074763002/ by danilchap@webrtc.org.

The reason for reverting is: breaks Win64 bots compile.

Powered by Google App Engine
This is Rietveld 408576698