Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Issue 2067423002: Unpack different wav files after each INIT event of the aecdump (Closed)

Created:
4 years, 6 months ago by aluebs-webrtc
Modified:
4 years, 6 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Unpack different wav files after each INIT event of the aecdump Some aecdumps have more than one INIT event. In those cases only the last wav file was unpacked, which sometimes is not the most interesting or desired one. This CL creates a different wav file after each INIT event. Committed: https://crrev.com/f03a8d4c4dabcc18b36bce6b093b7a8c29eca379 Cr-Commit-Position: refs/heads/master@{#13196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M webrtc/modules/audio_processing/test/unpack.cc View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
aluebs-webrtc
4 years, 6 months ago (2016-06-16 00:10:08 UTC) #2
hlundin-webrtc
Nice. LGTM.
4 years, 6 months ago (2016-06-17 10:33:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067423002/1
4 years, 6 months ago (2016-06-17 16:11:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 16:41:45 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 16:41:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f03a8d4c4dabcc18b36bce6b093b7a8c29eca379
Cr-Commit-Position: refs/heads/master@{#13196}

Powered by Google App Engine
This is Rietveld 408576698