webrtc/api/java/jni/androidmediaencoder_jni.cc - Issue 2067103002: Avoid unnecessary HW video encoder reconfiguration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/java/jni/androidmediaencoder_jni.cc

Issue 2067103002: Avoid unnecessary HW video encoder reconfiguration (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Code review feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/java/jni/androidmediaencoder_jni.cc

diff --git a/webrtc/api/java/jni/androidmediaencoder_jni.cc b/webrtc/api/java/jni/androidmediaencoder_jni.cc

index b76cfe7155e301d4646e6aaf63018707c9b59f63..47ceb690e423cfb22cfb1dbb1ce115208253a12a 100644

--- a/webrtc/api/java/jni/androidmediaencoder_jni.cc

+++ b/webrtc/api/java/jni/androidmediaencoder_jni.cc

@@ -416,7 +416,8 @@ int32_t MediaCodecVideoEncoder::InitEncode(

RTC_FROM_HERE,

Bind(&MediaCodecVideoEncoder::InitEncodeOnCodecThread, this, init_width,

init_height, codec_settings->startBitrate,

- codec_settings->maxFramerate, false /* use_surface */));

+ codec_settings->maxFramerate,

+ codec_settings->encode_from_texture /* use_surface */));

tommi 2016/06/15 21:00:39 remove the comment?

skvlad 2016/06/15 22:10:36 Done.

}

int32_t MediaCodecVideoEncoder::Encode(

« no previous file with comments | « no previous file | webrtc/common_types.h » ('j') | webrtc/common_types.h » ('J')