Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: webrtc/config.h

Issue 2067103002: Avoid unnecessary HW video encoder reconfiguration (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Optimistically guess rotation is supported Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 size_t width; 102 size_t width;
103 size_t height; 103 size_t height;
104 int max_framerate; 104 int max_framerate;
105 105
106 int min_bitrate_bps; 106 int min_bitrate_bps;
107 int target_bitrate_bps; 107 int target_bitrate_bps;
108 int max_bitrate_bps; 108 int max_bitrate_bps;
109 109
110 int max_qp; 110 int max_qp;
111 bool encode_from_texture;
perkj_webrtc 2016/06/15 11:31:29 remove this and move it to VideoEncoderConfig inst
skvlad 2016/06/15 19:44:34 Moving it to VideoEncoderConfig makes a lot of sen
111 112
112 // Bitrate thresholds for enabling additional temporal layers. Since these are 113 // Bitrate thresholds for enabling additional temporal layers. Since these are
113 // thresholds in between layers, we have one additional layer. One threshold 114 // thresholds in between layers, we have one additional layer. One threshold
114 // gives two temporal layers, one below the threshold and one above, two give 115 // gives two temporal layers, one below the threshold and one above, two give
115 // three, and so on. 116 // three, and so on.
116 // The VideoEncoder may redistribute bitrates over the temporal layers so a 117 // The VideoEncoder may redistribute bitrates over the temporal layers so a
117 // bitrate threshold of 100k and an estimate of 105k does not imply that we 118 // bitrate threshold of 100k and an estimate of 105k does not imply that we
118 // get 100k in one temporal layer and 5k in the other, just that the bitrate 119 // get 100k in one temporal layer and 5k in the other, just that the bitrate
119 // in the first temporal layer should not exceed 100k. 120 // in the first temporal layer should not exceed 100k.
120 // TODO(pbos): Apart from a special case for two-layer screencast these 121 // TODO(pbos): Apart from a special case for two-layer screencast these
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 struct VoicePacing { 170 struct VoicePacing {
170 VoicePacing() : enabled(false) {} 171 VoicePacing() : enabled(false) {}
171 explicit VoicePacing(bool value) : enabled(value) {} 172 explicit VoicePacing(bool value) : enabled(value) {}
172 static const ConfigOptionID identifier = ConfigOptionID::kVoicePacing; 173 static const ConfigOptionID identifier = ConfigOptionID::kVoicePacing;
173 bool enabled; 174 bool enabled;
174 }; 175 };
175 176
176 } // namespace webrtc 177 } // namespace webrtc
177 178
178 #endif // WEBRTC_CONFIG_H_ 179 #endif // WEBRTC_CONFIG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698