Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2067013003: Revert of Attempt to figure out what the issue is on the Win10 FYI build bot in content_browsertests. (Closed)

Created:
4 years, 6 months ago by tommi
Modified:
4 years, 6 months ago
Reviewers:
olka_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Attempt to figure out what the issue is on the Win10 FYI build bot in content_browsertests. (patchset #1 id:1 of https://codereview.webrtc.org/2063313003/ ) Reason for revert: Reverting after experiment. What seems to happen is that the thread can't be stopped when PostThreadMessage fails with this error code (or lack thereof). Original issue's description: > Attempt to figure out what the issue is on the Win10 FYI build bot in content_browsertests. > Check for the case when PostThreadMessage returns false but GetLastError returns ERROR_SUCCESS. > > TBR=olka > NOTRY=true > > Committed: https://crrev.com/e11041159d6e66fb25c2e045ad1558fc99d2d6cd > Cr-Commit-Position: refs/heads/master@{#13143} TBR=olka@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/42883f8b85662f77692f588f502ea44797989109 Cr-Commit-Position: refs/heads/master@{#13147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M webrtc/base/task_queue_win.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
tommi
4 years, 6 months ago (2016-06-14 23:06:18 UTC) #2
Created Revert of Attempt to figure out what the issue is on the Win10 FYI build
bot in content_browsertests.

Powered by Google App Engine
This is Rietveld 408576698