Add AudioSendStream::SetMuted() method and use it in WVoMC::MuteStream().

Add AudioSendStream::SetMuted() method and use it in WVoMC::MuteStream().

Removes the need to use VoEVolume::SetInputMute()/GetInputMute().

BUG=webrtc:4690
NOTRY=true

Committed: https://crrev.com/9421853e178151e5bf6f098a739da7a3db39528a
Cr-Commit-Position: refs/heads/master@{#13172}

[the sun, 2016-06-14 19:50:46]

Description was changed from

==========
Add AudioSendStream::SetMuted() method and use it in WVoMC::MuteStream().

BUG=webrtc:4690
==========

to

==========
Add AudioSendStream::SetMuted() method and use it in WVoMC::MuteStream().

Removes the need to use VoEVolume::SetInputMute()/GetInputMute().

BUG=webrtc:4690
==========

[the sun, 2016-06-14 19:54:29]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2016-06-16 09:33:45]

https://codereview.webrtc.org/2066973002/diff/1/webrtc/media/engine/webrtcvoe.h
File webrtc/media/engine/webrtcvoe.h (left):

https://codereview.webrtc.org/2066973002/diff/1/webrtc/media/engine/webrtcvoe...
webrtc/media/engine/webrtcvoe.h:26: #include
"webrtc/voice_engine/include/voe_network.h"
This appears unrelated to this CL?

https://codereview.webrtc.org/2066973002/diff/1/webrtc/media/engine/webrtcvoi...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2066973002/diff/1/webrtc/media/engine/webrtcvoi...
webrtc/media/engine/webrtcvoiceengine.cc:2393: all_muted = all_muted &&
kv.second->muted();
This looks like a job for std::all_of.

[the sun, 2016-06-16 12:31:38]

https://codereview.webrtc.org/2066973002/diff/1/webrtc/media/engine/webrtcvoe.h
File webrtc/media/engine/webrtcvoe.h (left):

https://codereview.webrtc.org/2066973002/diff/1/webrtc/media/engine/webrtcvoe...
webrtc/media/engine/webrtcvoe.h:26: #include
"webrtc/voice_engine/include/voe_network.h"
On 2016/06/16 09:33:45, kwiberg-webrtc wrote:
> This appears unrelated to this CL?

Yes, sorry.

https://codereview.webrtc.org/2066973002/diff/1/webrtc/media/engine/webrtcvoi...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2066973002/diff/1/webrtc/media/engine/webrtcvoi...
webrtc/media/engine/webrtcvoiceengine.cc:2393: all_muted = all_muted &&
kv.second->muted();
On 2016/06/16 09:33:45, kwiberg-webrtc wrote:
> This looks like a job for std::all_of.

That sounds neat, but it turns out it doesn't help readability a lot:

  bool all_muted =
      std::all_of(send_streams_.cbegin(), send_streams_.cend(),
                  [](const std::pair<uint32_t, WebRtcAudioSendStream*>& kv){
                      return kv.second->muted();
                  });

if all_of() had accepted send_streams_ without giving the iterators, and if we
could use auto in the lambda parameter list, then it would have been better,
though.

[kwiberg-webrtc, 2016-06-16 12:41:40]

lgtm

https://codereview.webrtc.org/2066973002/diff/1/webrtc/media/engine/webrtcvoi...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2066973002/diff/1/webrtc/media/engine/webrtcvoi...
webrtc/media/engine/webrtcvoiceengine.cc:2393: all_muted = all_muted &&
kv.second->muted();
On 2016/06/16 12:31:38, the sun wrote:
> On 2016/06/16 09:33:45, kwiberg-webrtc wrote:
> > This looks like a job for std::all_of.
> 
> That sounds neat, but it turns out it doesn't help readability a lot:
> 
>   bool all_muted =
>       std::all_of(send_streams_.cbegin(), send_streams_.cend(),
>                   [](const std::pair<uint32_t, WebRtcAudioSendStream*>& kv){
>                       return kv.second->muted();
>                   });
> 
> if all_of() had accepted send_streams_ without giving the iterators, and if we
> could use auto in the lambda parameter list, then it would have been better,
> though.

Bummer. auto in lambda parameter lists is in C++14, but not even C++17 will let
you mention send_streams_ less than twice.

[the sun, 2016-06-16 14:17:39]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2016-06-16 14:17:39]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2066973002/#ps40001 (title:
"Added a test case")

[commit-bot: I haz the power, 2016-06-16 14:17:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066973002/40001

[commit-bot: I haz the power, 2016-06-16 14:30:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 14:30:24]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[the sun, 2016-06-16 17:16:44]

Description was changed from

==========
Add AudioSendStream::SetMuted() method and use it in WVoMC::MuteStream().

Removes the need to use VoEVolume::SetInputMute()/GetInputMute().

BUG=webrtc:4690
==========

to

==========
Add AudioSendStream::SetMuted() method and use it in WVoMC::MuteStream().

Removes the need to use VoEVolume::SetInputMute()/GetInputMute().

BUG=webrtc:4690
NOTRY=true
==========

[the sun, 2016-06-16 17:51:40]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2016-06-16 17:51:40]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2066973002/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2016-06-16 17:51:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066973002/60001

[commit-bot: I haz the power, 2016-06-16 17:53:25]

Description was changed from

==========
Add AudioSendStream::SetMuted() method and use it in WVoMC::MuteStream().

Removes the need to use VoEVolume::SetInputMute()/GetInputMute().

BUG=webrtc:4690
NOTRY=true
==========

to

==========
Add AudioSendStream::SetMuted() method and use it in WVoMC::MuteStream().

Removes the need to use VoEVolume::SetInputMute()/GetInputMute().

BUG=webrtc:4690
NOTRY=true
==========

[commit-bot: I haz the power, 2016-06-16 17:53:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-16 17:53:35]

Description was changed from

==========
Add AudioSendStream::SetMuted() method and use it in WVoMC::MuteStream().

Removes the need to use VoEVolume::SetInputMute()/GetInputMute().

BUG=webrtc:4690
NOTRY=true
==========

to

==========
Add AudioSendStream::SetMuted() method and use it in WVoMC::MuteStream().

Removes the need to use VoEVolume::SetInputMute()/GetInputMute().

BUG=webrtc:4690
NOTRY=true

Committed: https://crrev.com/9421853e178151e5bf6f098a739da7a3db39528a
Cr-Commit-Position: refs/heads/master@{#13172}
==========

[commit-bot: I haz the power, 2016-06-16 17:53:37]

Patchset 4 (id:??) landed as
https://crrev.com/9421853e178151e5bf6f098a739da7a3db39528a
Cr-Commit-Position: refs/heads/master@{#13172}