Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2066863002:
Remove thread_checker in playout_delay_oracle (Closed)
|
Created:
4 years, 6 months ago by Irfan Modified:
4 years, 6 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove thread_checker in playout_delay_oracle
It appears there the encode and send operation can happen over multiple
threads. Also, padding data itself may be sent on a different thread.
Remove thread checker and protect all data with crit_sect.
BUG=webrtc:5998
TBR=stefan@webrtc.org
Committed: https://crrev.com/5aaa9faa9b93136699f907150992a64fed34a4db
Cr-Commit-Position: refs/heads/master@{#13137}
Patch Set 1 #
Messages
Total messages: 25 (12 generated)
Description was changed from ========== Remove thread_checker in playout_delay_oracle It appears there the encode and send operation can happen over multiple threads. Also, padding data itself may be sent on a different thread. Remove thread checker and protect all data with crit_sect. BUG=webrtc:5998 ========== to ========== Remove thread_checker in playout_delay_oracle It appears there the encode and send operation can happen over multiple threads. Also, padding data itself may be sent on a different thread. Remove thread checker and protect all data with crit_sect. BUG=webrtc:5998 ==========
isheriff@chromium.org changed reviewers: + pbos@webrtc.org, tkchin@webrtc.org
FYI, running a few tests on remoting.
pbos@chromium.org changed reviewers: + pbos@chromium.org
lgtm
The CQ bit was checked by isheriff@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066863002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by isheriff@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066863002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6288)
isheriff@chromium.org changed reviewers: + stefan@webrtc.org - pbos@chromium.org
Stefan, for OWNER lgtm. Please submit if it looks good as I am away traveling and will be offline for next several hours.
Description was changed from ========== Remove thread_checker in playout_delay_oracle It appears there the encode and send operation can happen over multiple threads. Also, padding data itself may be sent on a different thread. Remove thread checker and protect all data with crit_sect. BUG=webrtc:5998 ========== to ========== Remove thread_checker in playout_delay_oracle It appears there the encode and send operation can happen over multiple threads. Also, padding data itself may be sent on a different thread. Remove thread checker and protect all data with crit_sect. BUG=webrtc:5998 TBR=stefan@webrtc.org ==========
On 2016/06/14 17:47:35, Irfan wrote: > Stefan, for OWNER lgtm. > > Please submit if it looks good as I am away traveling and will be offline for > next several hours. +TBR, submitting. This breaks HW-encoder debug builds.
The CQ bit was checked by pbos@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066863002/1
Message was sent while issue was closed.
Description was changed from ========== Remove thread_checker in playout_delay_oracle It appears there the encode and send operation can happen over multiple threads. Also, padding data itself may be sent on a different thread. Remove thread checker and protect all data with crit_sect. BUG=webrtc:5998 TBR=stefan@webrtc.org ========== to ========== Remove thread_checker in playout_delay_oracle It appears there the encode and send operation can happen over multiple threads. Also, padding data itself may be sent on a different thread. Remove thread checker and protect all data with crit_sect. BUG=webrtc:5998 TBR=stefan@webrtc.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Remove thread_checker in playout_delay_oracle It appears there the encode and send operation can happen over multiple threads. Also, padding data itself may be sent on a different thread. Remove thread checker and protect all data with crit_sect. BUG=webrtc:5998 TBR=stefan@webrtc.org ========== to ========== Remove thread_checker in playout_delay_oracle It appears there the encode and send operation can happen over multiple threads. Also, padding data itself may be sent on a different thread. Remove thread checker and protect all data with crit_sect. BUG=webrtc:5998 TBR=stefan@webrtc.org Committed: https://crrev.com/5aaa9faa9b93136699f907150992a64fed34a4db Cr-Commit-Position: refs/heads/master@{#13137} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5aaa9faa9b93136699f907150992a64fed34a4db Cr-Commit-Position: refs/heads/master@{#13137} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
