Android: Add Size class.

Android: Add Size class.

The Camera1 and Camera2 API use different size types. Camera1 uses
android.hardware.Camera.Size while Camera2 uses android.util.Size.
android.util.Size is only available from Lollipop forward so this CL
adds a similar Size class in CaptureFormat.

The purpose of this CL is to have a common size type that can be reused
from both Camera1 and Camera2 helper functions such as
CameraEnumerationAndroid.getClosestSupportedSize().

BUG=webrtc:5519
Committed: https://crrev.com/e6c9e88c18e56d2f3084f551911cbf40a427f7f5
Cr-Commit-Position: refs/heads/master@{#13181}

[sakal, 2016-06-14 12:45:59]

Description was changed from

==========
Android: Add Size class.

The Camera1 and Camera2 API use different size types. Camera1 uses
android.hardware.Camera.Size while Camera2 uses android.util.Size.
android.util.Size is only available from Lollipop forward so this CL
adds a similar Size class in CaptureFormat.

The purpose of this CL is to have a common size type that can be reused
from both Camera1 and Camera2 helper functions such as
CameraEnumerationAndroid.getClosestSupportedSize().

BUG=webrtc:5519
==========

to

==========
Android: Add Size class.

The Camera1 and Camera2 API use different size types. Camera1 uses
android.hardware.Camera.Size while Camera2 uses android.util.Size.
android.util.Size is only available from Lollipop forward so this CL
adds a similar Size class in CaptureFormat.

The purpose of this CL is to have a common size type that can be reused
from both Camera1 and Camera2 helper functions such as
CameraEnumerationAndroid.getClosestSupportedSize().

BUG=webrtc:5519
==========

[sakal, 2016-06-14 12:45:59]

sakal@webrtc.org changed reviewers:
+ perkj@webrtc.org

[sakal, 2016-06-14 12:46:13]

On 2016/06/14 12:45:59, sakal wrote:
> mailto:sakal@webrtc.org changed reviewers:
> + mailto:perkj@webrtc.org

Per, please take a look.

[perkj_webrtc, 2016-06-14 13:01:19]

Does this affect current products? Is anyone using CaptureFormat directly?

https://codereview.webrtc.org/2066773002/diff/1/webrtc/examples/androidapp/sr...
File
webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java
(right):

https://codereview.webrtc.org/2066773002/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java:58:
return first.size.width * first.size.height - second.size.width *
second.size.height;
first.size.GetArea()- second.size.GetArea() ?

https://codereview.webrtc.org/2066773002/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java:80:
(long) format.size.width * format.size.height * format.framerate.max);
size.GetArea() ?

https://codereview.webrtc.org/2066773002/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java:96:
captureFormatText.setText(width + "x" + height + " @ " + framerate + "fps");
size.ToString on line 96 ?

https://codereview.webrtc.org/2066773002/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java:111:
(int) Math.round(bandwidth / (format.size.width * format.size.height))) /
1000.0);
nit size.GetArea() = ?

[sakal, 2016-06-14 13:12:51]

https://codereview.webrtc.org/2066773002/diff/1/webrtc/examples/androidapp/sr...
File
webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java
(right):

https://codereview.webrtc.org/2066773002/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java:58:
return first.size.width * first.size.height - second.size.width *
second.size.height;
On 2016/06/14 13:01:19, perkj_webrtc wrote:
> first.size.GetArea()- second.size.GetArea() ? 

Done.

https://codereview.webrtc.org/2066773002/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java:80:
(long) format.size.width * format.size.height * format.framerate.max);
On 2016/06/14 13:01:19, perkj_webrtc wrote:
> size.GetArea() ?

Done.

https://codereview.webrtc.org/2066773002/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java:96:
captureFormatText.setText(width + "x" + height + " @ " + framerate + "fps");
On 2016/06/14 13:01:19, perkj_webrtc wrote:
> size.ToString on line 96 ? 

Done.

https://codereview.webrtc.org/2066773002/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java:111:
(int) Math.round(bandwidth / (format.size.width * format.size.height))) /
1000.0);
On 2016/06/14 13:01:19, perkj_webrtc wrote:
> nit size.GetArea() = ?

Done.

[sakal, 2016-06-15 13:29:36]

Patchset #4 (id:60001) has been deleted

[sakal, 2016-06-15 13:32:04]

Per, like discussed offline, I changed the code to only use Size class in the
getClosestSupportedSize.

[sakal, 2016-06-15 13:32:44]

Patchset #4 (id:80001) has been deleted

[perkj_webrtc, 2016-06-16 12:16:31]

lgtm

https://codereview.webrtc.org/2066773002/diff/40001/webrtc/api/java/android/o...
File webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java (right):

https://codereview.webrtc.org/2066773002/diff/40001/webrtc/api/java/android/o...
webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java:114: public int
frameSize() {
oh, sorry, we should probably replace size.GetArea with frameArea... and add a
comment what the difference is.

[sakal, 2016-06-16 12:40:53]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 12:40:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066773002/140001

[commit-bot: I haz the power, 2016-06-16 13:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 13:13:35]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[sakal, 2016-06-16 13:36:23]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-06-16 13:36:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066773002/140001

[commit-bot: I haz the power, 2016-06-16 14:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 14:00:36]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[sakal, 2016-06-17 07:01:10]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-06-17 07:01:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066773002/140001

[commit-bot: I haz the power, 2016-06-17 08:02:06]

Description was changed from

==========
Android: Add Size class.

The Camera1 and Camera2 API use different size types. Camera1 uses
android.hardware.Camera.Size while Camera2 uses android.util.Size.
android.util.Size is only available from Lollipop forward so this CL
adds a similar Size class in CaptureFormat.

The purpose of this CL is to have a common size type that can be reused
from both Camera1 and Camera2 helper functions such as
CameraEnumerationAndroid.getClosestSupportedSize().

BUG=webrtc:5519
==========

to

==========
Android: Add Size class.

The Camera1 and Camera2 API use different size types. Camera1 uses
android.hardware.Camera.Size while Camera2 uses android.util.Size.
android.util.Size is only available from Lollipop forward so this CL
adds a similar Size class in CaptureFormat.

The purpose of this CL is to have a common size type that can be reused
from both Camera1 and Camera2 helper functions such as
CameraEnumerationAndroid.getClosestSupportedSize().

BUG=webrtc:5519
==========

[commit-bot: I haz the power, 2016-06-17 08:02:07]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-06-17 08:02:19]

Description was changed from

==========
Android: Add Size class.

The Camera1 and Camera2 API use different size types. Camera1 uses
android.hardware.Camera.Size while Camera2 uses android.util.Size.
android.util.Size is only available from Lollipop forward so this CL
adds a similar Size class in CaptureFormat.

The purpose of this CL is to have a common size type that can be reused
from both Camera1 and Camera2 helper functions such as
CameraEnumerationAndroid.getClosestSupportedSize().

BUG=webrtc:5519
==========

to

==========
Android: Add Size class.

The Camera1 and Camera2 API use different size types. Camera1 uses
android.hardware.Camera.Size while Camera2 uses android.util.Size.
android.util.Size is only available from Lollipop forward so this CL
adds a similar Size class in CaptureFormat.

The purpose of this CL is to have a common size type that can be reused
from both Camera1 and Camera2 helper functions such as
CameraEnumerationAndroid.getClosestSupportedSize().

BUG=webrtc:5519

Committed: https://crrev.com/e6c9e88c18e56d2f3084f551911cbf40a427f7f5
Cr-Commit-Position: refs/heads/master@{#13181}
==========

[commit-bot: I haz the power, 2016-06-17 08:02:20]

Patchset 6 (id:??) landed as
https://crrev.com/e6c9e88c18e56d2f3084f551911cbf40a427f7f5
Cr-Commit-Position: refs/heads/master@{#13181}