Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2066443003: Add SigslotTester0 for testing signals without argument. (Closed)

Created:
4 years, 6 months ago by honghaiz3
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add SigslotTester0 for testing signals without argument. BUG= Committed: https://crrev.com/4deba9adf141a4d08dae7ea1b5aa13dd8a22fbb0 Cr-Commit-Position: refs/heads/master@{#13141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M webrtc/base/sigslottester.h View 1 chunk +18 lines, -1 line 0 comments Download
M webrtc/base/sigslottester.h.pump View 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
honghaiz3
4 years, 6 months ago (2016-06-13 23:24:26 UTC) #2
pthatcher1
lgtm
4 years, 6 months ago (2016-06-14 19:12:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066443003/1
4 years, 6 months ago (2016-06-14 19:48:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 19:49:53 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 19:50:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4deba9adf141a4d08dae7ea1b5aa13dd8a22fbb0
Cr-Commit-Position: refs/heads/master@{#13141}

Powered by Google App Engine
This is Rietveld 408576698