Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2066233002: Remove SdpAudioFormat's default constructor (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 6 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove SdpAudioFormat's default constructor We didn't really want it; it was only necessary because we wanted to use rtc::Optional<SdpAudioFormat>, and Optional used to require the contained type to be default constructable. But as of May 9th (https://codereview.webrtc.org/1896833004), it no longer does. Committed: https://crrev.com/44bf02fba2d0d6c2c1b08ea09e2a0cd2e8b93846 Cr-Commit-Position: refs/heads/master@{#13211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M webrtc/modules/audio_coding/codecs/audio_format.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_format.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 6 months ago (2016-06-15 11:48:19 UTC) #2
ossu
lgtm
4 years, 6 months ago (2016-06-20 08:25:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066233002/1
4 years, 6 months ago (2016-06-20 09:04:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 09:39:53 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 09:39:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44bf02fba2d0d6c2c1b08ea09e2a0cd2e8b93846
Cr-Commit-Position: refs/heads/master@{#13211}

Powered by Google App Engine
This is Rietveld 408576698