Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2065583002: GN: Fix 32-bit Mac library error (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix 32-bit Mac library error The error hasn't been noticed since we don't really do (or support) Mac 32-bit builds. BUG=webrtc:5949 NOTRY=True Committed: https://crrev.com/781e0c03a2315bccf0321dad66b8714c1e846c51 Cr-Commit-Position: refs/heads/master@{#13111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-13 11:51:21 UTC) #2
Nico
lgtm, thanks! https://codereview.webrtc.org/2041743003/ didn't really introduce the error now that I look at it more, ...
4 years, 6 months ago (2016-06-13 12:12:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065583002/1
4 years, 6 months ago (2016-06-13 12:39:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 12:41:18 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 12:41:19 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 12:41:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/781e0c03a2315bccf0321dad66b8714c1e846c51
Cr-Commit-Position: refs/heads/master@{#13111}

Powered by Google App Engine
This is Rietveld 408576698