Delete unused code.

Delete unused code.

* Unused audio_coding and video_coding test code.
* Obsolete voice_engine android test app.
* Left-over placeholder files for remoteaudiotrack and
  portallocatorfactory.

In addition, change modules.gyp dependency from rtc_base to
rtc_base_approved.

BUG=
R=henrik.lundin@webrtc.org, henrika@webrtc.org, pbos@webrtc.org, tina.legrand@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/fc3a8ee47b5998e07844da04bf9c3f1bd46040a2

[nisse-webrtc, 2016-06-15 07:35:50]

nisse@webrtc.org changed reviewers:
+ henrika@webrtc.org

[nisse-webrtc, 2016-06-15 07:35:50]

Can you have a look?

The place-holder files can be deleted because references from chrome's libjingle
files were deleted the other day.

As for the audio_coding and voice_engine tests, do you know the history of these
tests, the simpleKenny.c file and the android test app? According to commit
messages, the latter was in working shape back in 2011, but seems to no longer
be included in the android build of webrtc.

[henrika_webrtc, 2016-06-15 08:29:06]

LGTM for all under voice_engine.

But I don't know the history of the other parts. Sorry.

[nisse-webrtc, 2016-06-15 09:07:53]

nisse@webrtc.org changed reviewers:
+ kwiberg@webrtc.org, pbos@webrtc.org

[nisse-webrtc, 2016-06-15 09:07:54]

Thanks for the review.

kwiberg and pbos, are you familiar with the audio_coding and video_coding tests?

[kwiberg-webrtc, 2016-06-15 09:31:28]

Description was changed from

==========
Delete unused code.

* Unused audio_coding and video_coding test code.
* Obsolete voice_engine android test app.
* Left-over placeholder files for remoteaudiotrack and
  portallocatorfactory.

In addition, change modules.gyp dependency from rtc_base to
rtc_base_approved.

BUG=
==========

to

==========
Delete unused code.

* Unused audio_coding and video_coding test code.
* Obsolete voice_engine android test app.
* Left-over placeholder files for remoteaudiotrack and
  portallocatorfactory.

In addition, change modules.gyp dependency from rtc_base to
rtc_base_approved.

BUG=
==========

[kwiberg-webrtc, 2016-06-15 09:31:28]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, tina.legrand@webrtc.org

[kwiberg-webrtc, 2016-06-15 09:31:37]

On 2016/06/15 09:07:54, nisse-webrtc wrote:
> Thanks for the review.
> 
> kwiberg and pbos, are you familiar with the audio_coding and video_coding
tests?

Not really. Adding tlegrand@ and hlundin@ to the discussion.

[tlegrand-webrtc, 2016-06-15 10:12:36]

On 2016/06/15 09:31:37, kwiberg-webrtc wrote:
> On 2016/06/15 09:07:54, nisse-webrtc wrote:
> > Thanks for the review.
> > 
> > kwiberg and pbos, are you familiar with the audio_coding and video_coding
> tests?
> 
> Not really. Adding tlegrand@ and hlundin@ to the discussion.

simpleKenny.c is a tool to run the iSAC codec "offline", to generate encoded and
decoded frames. We're not using it much, but I don't think you need to spend any
more time on it. Was there any specific problem with the iSAC test?

[nisse-webrtc, 2016-06-15 10:54:49]

On 2016/06/15 10:12:36, tlegrand-webrtc wrote:
> On 2016/06/15 09:31:37, kwiberg-webrtc wrote:
> > On 2016/06/15 09:07:54, nisse-webrtc wrote:
> > > Thanks for the review.
> > > 
> > > kwiberg and pbos, are you familiar with the audio_coding and video_coding
> > tests?
> > 
> > Not really. Adding tlegrand@ and hlundin@ to the discussion.
> 
> simpleKenny.c is a tool to run the iSAC codec "offline", to generate encoded
and
> decoded frames. We're not using it much, but I don't think you need to spend
any
> more time on it. Was there any specific problem with the iSAC test?

No problem with the test, I just wanted to delete the unused debugUtility.h,
and drop the conditional inclusion of it in simpleKenny.c. As far as I
understand, 
it's used if HAVE_DEBUG_INFO is defined, which it isn't, and then it depends on
files like
"Res0to4.dat" which seem non-existant. And while removing #if HAVE_DEBUG_INFO in
simpleKenny.c, 
I removed other #if:ed out code and commented out code while at it. 

No functional changes intended.

[tlegrand-webrtc, 2016-06-15 12:02:49]

On 2016/06/15 10:54:49, nisse-webrtc wrote:
> On 2016/06/15 10:12:36, tlegrand-webrtc wrote:
> > On 2016/06/15 09:31:37, kwiberg-webrtc wrote:
> > > On 2016/06/15 09:07:54, nisse-webrtc wrote:
> > > > Thanks for the review.
> > > > 
> > > > kwiberg and pbos, are you familiar with the audio_coding and
video_coding
> > > tests?
> > > 
> > > Not really. Adding tlegrand@ and hlundin@ to the discussion.
> > 
> > simpleKenny.c is a tool to run the iSAC codec "offline", to generate encoded
> and
> > decoded frames. We're not using it much, but I don't think you need to spend
> any
> > more time on it. Was there any specific problem with the iSAC test?
> 
> No problem with the test, I just wanted to delete the unused debugUtility.h,
> and drop the conditional inclusion of it in simpleKenny.c. As far as I
> understand, 
> it's used if HAVE_DEBUG_INFO is defined, which it isn't, and then it depends
on
> files like
> "Res0to4.dat" which seem non-existant. And while removing #if HAVE_DEBUG_INFO
in
> simpleKenny.c, 
> I removed other #if:ed out code and commented out code while at it. 
> 
> No functional changes intended.

So, I think this is a multi-step-debug-tool, that we haven't used in 5 years or
so. :) I think that you needed to compile the codec with some flag, then run it
with SimpleKenny to get the *.dat files, and then rebuild SimpleKenny with the
debug setting before running again.

I don't expect us to every use that functionality again, so I like this change. 

LGTM for the isac changes.

[hlundin-webrtc, 2016-06-15 12:35:19]

webrtc/modules/audio_coding/: lgtm

[nisse-webrtc, 2016-06-16 11:11:01]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 11:11:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065353002/1

[commit-bot: I haz the power, 2016-06-16 11:22:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 11:22:16]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[pbos-webrtc, 2016-06-16 11:22:34]

lgtm for video_coding/test

[nisse-webrtc, 2016-06-16 12:19:53]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-06-16 12:19:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065353002/1

[commit-bot: I haz the power, 2016-06-16 13:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 13:06:55]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[nisse-webrtc, 2016-06-16 13:12:04]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-06-16 13:12:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065353002/1

[commit-bot: I haz the power, 2016-06-16 13:43:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 13:43:08]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[nisse-webrtc, 2016-06-16 13:51:45]

Description was changed from

==========
Delete unused code.

* Unused audio_coding and video_coding test code.
* Obsolete voice_engine android test app.
* Left-over placeholder files for remoteaudiotrack and
  portallocatorfactory.

In addition, change modules.gyp dependency from rtc_base to
rtc_base_approved.

BUG=
==========

to

==========
Delete unused code.

* Unused audio_coding and video_coding test code.
* Obsolete voice_engine android test app.
* Left-over placeholder files for remoteaudiotrack and
  portallocatorfactory.

In addition, change modules.gyp dependency from rtc_base to
rtc_base_approved.

BUG=
R=henrik.lundin@webrtc.org, henrika@webrtc.org, pbos@webrtc.org,
tina.legrand@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/fc3a8ee47b5998e07844da04b...
==========

[commit-bot: I haz the power, 2016-06-16 13:51:46]

Description was changed from

==========
Delete unused code.

* Unused audio_coding and video_coding test code.
* Obsolete voice_engine android test app.
* Left-over placeholder files for remoteaudiotrack and
  portallocatorfactory.

In addition, change modules.gyp dependency from rtc_base to
rtc_base_approved.

BUG=
R=henrik.lundin@webrtc.org, henrika@webrtc.org, pbos@webrtc.org,
tina.legrand@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/fc3a8ee47b5998e07844da04b...
==========

to

==========
Delete unused code.

* Unused audio_coding and video_coding test code.
* Obsolete voice_engine android test app.
* Left-over placeholder files for remoteaudiotrack and
  portallocatorfactory.

In addition, change modules.gyp dependency from rtc_base to
rtc_base_approved.

BUG=
R=henrik.lundin@webrtc.org, henrika@webrtc.org, pbos@webrtc.org,
tina.legrand@webrtc.org

Committed: https://crrev.com/fc3a8ee47b5998e07844da04bf9c3f1bd46040a2
Cr-Commit-Position: refs/heads/master@{#13166}
==========

[nisse-webrtc, 2016-06-16 13:51:47]

Committed patchset #2 (id:20001) manually as
fc3a8ee47b5998e07844da04bf9c3f1bd46040a2 (presubmit successful).