Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: webrtc/p2p/base/transport.h

Issue 2063823008: Adding IceConfig option to assume TURN/TURN candidate pairs will work. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/p2p/base/p2ptransportchannel_unittest.cc ('K') | « webrtc/p2p/base/port.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/transport.h
diff --git a/webrtc/p2p/base/transport.h b/webrtc/p2p/base/transport.h
index 9b6cf519f89106885da65972fd605d1f6beb1766..07c2a99789dd2fe0f25b960cfd84b4608f22933f 100644
--- a/webrtc/p2p/base/transport.h
+++ b/webrtc/p2p/base/transport.h
@@ -152,6 +152,8 @@ struct TransportStats {
};
// Information about ICE configuration.
+// TODO(deadbeef): Use rtc::Optional to represent unset values, instead of
+// -1.
struct IceConfig {
// The ICE connection receiving timeout value in milliseconds.
int receiving_timeout = -1;
@@ -170,18 +172,27 @@ struct IceConfig {
// (Default value is a little less than 2 * STRONG_PING_INTERVAL).
int max_strong_interval = -1;
+ // If set to false, this means the ICE transport can expect TURN-to-TURN
+ // candidate pairs to work even before CreatePermission requests are sent
+ // to the TURN servers. This allows media to be sent earlier, without even
+ // requiring binding request/responses to verify that the connection works.
+ bool turn_to_turn_createpermission_needed = true;
+
IceConfig() {}
IceConfig(int receiving_timeout_ms,
int backup_connection_ping_interval,
bool gather_continually,
bool prioritize_most_likely_candidate_pairs,
- int max_strong_interval_ms)
+ int max_strong_interval_ms,
+ bool turn_to_turn_no_createpermission_needed)
: receiving_timeout(receiving_timeout_ms),
backup_connection_ping_interval(backup_connection_ping_interval),
gather_continually(gather_continually),
prioritize_most_likely_candidate_pairs(
prioritize_most_likely_candidate_pairs),
- max_strong_interval(max_strong_interval_ms) {}
+ max_strong_interval(max_strong_interval_ms),
+ turn_to_turn_createpermission_needed(
+ turn_to_turn_no_createpermission_needed) {}
};
bool BadTransportDescription(const std::string& desc, std::string* err_desc);
« webrtc/p2p/base/p2ptransportchannel_unittest.cc ('K') | « webrtc/p2p/base/port.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698