Resolves issue with bad audio using BT headsets on iOS

webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm

 /*
  *  Copyright 2016 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 618 matching lines @@
   // TODO(tkchin): Figure out if this is really necessary.
   if (!self.inputAvailable) {
     RTCLogError(@"No audio input path is available!");
     [self unconfigureWebRTCSession:nil];
     if (outError) {
       *outError = [self configurationErrorWithDescription:@"No input path."];
     }
     return NO;
   }
 
+  // It can happen (e.g. in combination with BT devices) that the attempt to set
+  // the preferred sample rate for WebRTC (48kHz) fails. If so, make a new
+  // configuration attempt using the sample rate that worked using the active
+  // audio session. A typical case is that only 8 or 16kHz can be set, e.g. in
+  // combination with BT headsets. Using this "trick" seems to avoid a state
+  // where Core Audio asks for a different number of audio frames than what the
+  // session's I/O buffer duration corresponds to.
+  // TODO(henrika): this fix resolves bugs.webrtc.org/6004 but it has only been
+  // tested on a limited set of iOS devices and BT devices.
+  double session_sample_rate = self.sampleRate;

[tkchin_webrtc, 2016/06/15 21:21:46]

in ObjC methods, use ObjC style rules. Camel case instead of underscore.

e.g sessionSampleRate 

[henrika_webrtc, 2016/06/16 12:12:26]

Done.

+  double preferred_sample_rate = webRTCConfig.sampleRate;
+  if (session_sample_rate != preferred_sample_rate) {
+    RTCLogWarning(

[tkchin_webrtc, 2016/06/15 21:21:46]

fyi I've made it to that ObjC files are now 100char (consistent with ObjC style)

[henrika_webrtc, 2016/06/16 12:12:26]

Got it. Keeping 80 here to be consistent with the rest of the file.

+        @"Current sample rate (%.2f) is not the preferred rate (%.2f)",
+        session_sample_rate, preferred_sample_rate);
+    if (![self setPreferredSampleRate:session_sample_rate
+                                error:&error]) {
+      RTCLogError(@"Failed to set preferred sample rate: %@",
+                  error.localizedDescription);
+      if (outError) {
+        *outError = error;
+      }
+    }
+  }
+
   return YES;
 }
 
 - (BOOL)unconfigureWebRTCSession:(NSError **)outError {
   if (outError) {
     *outError = nil;
   }
   if (![self checkLock:outError]) {
     return NO;
   }
@@ skipping 114 matching lines @@
 - (void)notifyDidStopPlayOrRecord {
   for (auto delegate : self.delegates) {
     SEL sel = @selector(audioSessionDidStopPlayOrRecord:);
     if ([delegate respondsToSelector:sel]) {
       [delegate audioSessionDidStopPlayOrRecord:self];
     }
   }
 }
 
 @end