Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2063643003: Reland of Re-enable UBsan on AGC. (Closed)

Created:
4 years, 6 months ago by minyue-webrtc
Modified:
4 years, 6 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Re-enable UBsan on AGC. patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/ This reverts commit 2b9423f7a18145255deb93f2505a4fd1c3fa9ad7. BUG=webrtc:5530 TBR=peah@webrtc.org, kjellander@webrtc.org Committed: https://crrev.com/b1963b403f8e9258c35a02d2622da254cbb90c51 Cr-Commit-Position: refs/heads/master@{#13132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -25 lines) Patch
M tools/ubsan/blacklist.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/agc/legacy/analog_agc.c View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/agc/legacy/digital_agc.c View 2 chunks +6 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
minyue-webrtc
Hi Henrik, This is actually the same CL as the one landed earlier. The blocker ...
4 years, 6 months ago (2016-06-13 15:00:52 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063643003/1
4 years, 6 months ago (2016-06-14 08:47:23 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 10:34:34 UTC) #9
hlundin-webrtc
There is a typo in the description: Relan -> Reland. Other than that, lgtm.
4 years, 6 months ago (2016-06-14 11:57:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063643003/1
4 years, 6 months ago (2016-06-14 14:10:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 14:18:16 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b1963b403f8e9258c35a02d2622da254cbb90c51 Cr-Commit-Position: refs/heads/master@{#13132}
4 years, 6 months ago (2016-06-14 14:18:26 UTC) #17
pbos-webrtc
4 years, 6 months ago (2016-06-16 14:50:40 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2078433003/ by pbos@webrtc.org.

The reason for reverting is: Breaks downstream code import..

Powered by Google App Engine
This is Rietveld 408576698