Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2063313003: Attempt to figure out what the issue is on the Win10 FYI build bot in content_browsertests. (Closed)

Created:
4 years, 6 months ago by tommi
Modified:
4 years, 6 months ago
Reviewers:
olka_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Attempt to figure out what the issue is on the Win10 FYI build bot in content_browsertests. Check for the case when PostThreadMessage returns false but GetLastError returns ERROR_SUCCESS. TBR=olka NOTRY=true Committed: https://crrev.com/e11041159d6e66fb25c2e045ad1558fc99d2d6cd Cr-Commit-Position: refs/heads/master@{#13143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M webrtc/base/task_queue_win.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
tommi
4 years, 6 months ago (2016-06-14 21:32:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063313003/1
4 years, 6 months ago (2016-06-14 21:32:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 21:37:59 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e11041159d6e66fb25c2e045ad1558fc99d2d6cd Cr-Commit-Position: refs/heads/master@{#13143}
4 years, 6 months ago (2016-06-14 21:38:13 UTC) #9
tommi
4 years, 6 months ago (2016-06-14 23:06:17 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2067013003/ by tommi@webrtc.org.

The reason for reverting is: Reverting after experiment.  What seems to happen
is that the thread can't be stopped when PostThreadMessage fails with this error
code (or lack thereof)..

Powered by Google App Engine
This is Rietveld 408576698