Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2061943003: Always send RED headers if configured. (Closed)

Created:
4 years, 6 months ago by pbos-webrtc
Modified:
4 years, 6 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@52
Target Ref:
refs/pending/branch-heads/52
Project:
webrtc
Visibility:
Public.

Description

Always send RED headers if configured. This shouldn't be needed, but because the receiver assumes RTX packets contain RED if configured to receive them (due to an incompatibility issue), we also have to make sure we send them for now. BUG=webrtc:5675 Review-Url: https://codereview.webrtc.org/2033763002 Cr-Commit-Position: refs/heads/master@{#13024} (cherry picked from commit 8f4c77fea10010b5879a01bf6fcd485318594a85) TBR=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/3446611ec58e3e218371debc798899fac7ff2e00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -28 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 6 chunks +16 lines, -11 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 2 chunks +12 lines, -9 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 6 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
pbos-webrtc
4 years, 6 months ago (2016-06-14 14:26:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3446611ec58e3e218371debc798899fac7ff2e00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698