Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2061923004: Change RTC_CHECK to RTC_CHECK_EQ for improved printout of GetLastError. (Closed)

Created:
4 years, 6 months ago by tommi
Modified:
4 years, 6 months ago
Reviewers:
olka_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change RTC_CHECK to RTC_CHECK_EQ for improved printout of GetLastError. TBR=olka@webrtc.org NOTRY=true Committed: https://crrev.com/8b06ec0b716e35819229d155f0f421ba539e474b Cr-Commit-Position: refs/heads/master@{#13134}

Patch Set 1 #

Patch Set 2 : static_cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/base/task_queue_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
tommi
4 years, 6 months ago (2016-06-14 15:14:09 UTC) #3
tommi
static_cast
4 years, 6 months ago (2016-06-14 15:16:25 UTC) #5
olka_webrtc
On 2016/06/14 15:16:25, tommi-webrtc wrote: > static_cast lgtm
4 years, 6 months ago (2016-06-14 15:27:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061923004/20001
4 years, 6 months ago (2016-06-14 15:36:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 15:38:11 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 15:38:21 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b06ec0b716e35819229d155f0f421ba539e474b
Cr-Commit-Position: refs/heads/master@{#13134}

Powered by Google App Engine
This is Rietveld 408576698