webrtc/tools/author_line_count - Issue 2061683002: New misc scripts, header_usage.sh and author_line_count.sh.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/tools/author_line_count

Issue 2061683002: New misc scripts, header_usage.sh and author_line_count.sh. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #! /bin/sh
	kjellander_webrtc 2016/06/13 12:49:52 Provide a brief description. Provide a brief description. kjellander_webrtc 2016/06/13 12:49:52 Change to #!/bin/bash Change to #!/bin/bash nisse-webrtc 2016/06/14 09:38:47 Done. Show quoted text On 2016/06/13 12:49:52, kjellander_webrtc wrote: > Change to #!/bin/bash Done. kjellander_webrtc 2016/06/14 14:11:12 Not done :) Still needs to remove the space. Show quoted text On 2016/06/14 09:38:47, nisse-webrtc wrote: > On 2016/06/13 12:49:52, kjellander_webrtc wrote: > > Change to #!/bin/bash > > Done. Not done :) Still needs to remove the space. nisse-webrtc 2016/06/15 06:55:23 Ok. That's unorthodox, script files are traditiona Show quoted text On 2016/06/14 14:11:12, kjellander_webrtc wrote: > On 2016/06/14 09:38:47, nisse-webrtc wrote: > > On 2016/06/13 12:49:52, kjellander_webrtc wrote: > > > Change to #!/bin/bash > > > > Done. > > Not done :) Still needs to remove the space. Ok. That's unorthodox, script files are traditionally assumed to use the 32-bit magic number "#! /".
	2

	3 AUTHOR=$1

	4 if [ -z "$AUTHOR" ] ; then
	kjellander_webrtc 2016/06/13 12:49:51 Prefer brace-quoting of multiple-character variabl Prefer brace-quoting of multiple-character variables: https://engdoc.corp.google.com/eng/doc/shell.xml?showone=Variable_expansion&c... kjellander_webrtc 2016/06/13 12:49:52 Use [[ ]] style test. https://engdoc.corp.google.c Use [[ ]] style test. https://engdoc.corp.google.com/eng/doc/shell.xml?cl=head#Test,_%5B_and_%5B%5B nisse-webrtc 2016/06/14 09:38:46 Done. Show quoted text On 2016/06/13 12:49:52, kjellander_webrtc wrote: > Use [[ ]] style test. > https://engdoc.corp.google.com/eng/doc/shell.xml?cl=head#Test,_%5B_and_%5B%5B Done.
	5 echo "Usage: $0 AUTHOR-PATTERN"

	6 exit 1

	7 fi

	8

	9 git log --author="$AUTHOR" --oneline --shortstat \| grep '^ ' \| gawk '

	10 BEGIN { RS=",\|\n" }

	11 /insertion/ { total += $1 }

	12 /deletion/ { total -= $1 }

	13 END { print total }

	14 '

	15

OLD	NEW

« no previous file with comments | « no previous file | webrtc/tools/header_usage » ('j') | webrtc/tools/header_usage » ('J')